Add RecomposeComplexOps declaration + fix typos in pass name
#1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `RecomposeComplexOps` pass currently does not have a TableGen declaration and it is using the base class of `DecomposeComplexOps`, which causes `--mlir-print-ir-after-all` to create wrong pass labels. This commit fixes that as well as some minor typos in the name of the pass.
|
Not sure how I missed this when I reviewed your patch, @gpetters94 |
|
@gpetters94, PTAL |
gpetters94
pushed a commit
to gpetters94/mlir-npcomp
that referenced
this pull request
May 10, 2023
…1950) The `RecomposeComplexOps` pass currently does not have a TableGen declaration and it is using the base class of `DecomposeComplexOps`, which causes `--mlir-print-ir-after-all` to create wrong pass labels. This commit fixes that as well as some minor typos in the name of the pass.
gpetters94
pushed a commit
to gpetters94/mlir-npcomp
that referenced
this pull request
Jul 7, 2023
…1950) The `RecomposeComplexOps` pass currently does not have a TableGen declaration and it is using the base class of `DecomposeComplexOps`, which causes `--mlir-print-ir-after-all` to create wrong pass labels. This commit fixes that as well as some minor typos in the name of the pass.
gpetters94
pushed a commit
to gpetters94/mlir-npcomp
that referenced
this pull request
Jul 7, 2023
…1950) The `RecomposeComplexOps` pass currently does not have a TableGen declaration and it is using the base class of `DecomposeComplexOps`, which causes `--mlir-print-ir-after-all` to create wrong pass labels. This commit fixes that as well as some minor typos in the name of the pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RecomposeComplexOpspass currently does not have a TableGen declaration and it is using the base class ofDecomposeComplexOps, which causes--mlir-print-ir-after-allto create wrong pass labels. This commit fixes that as well as some minor typos in the name of the pass.