Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOSA] Add aten.view shape -1 support #1815

Merged
merged 1 commit into from
Jan 20, 2023
Merged

[TOSA] Add aten.view shape -1 support #1815

merged 1 commit into from
Jan 20, 2023

Conversation

AmosLewis
Copy link
Collaborator

@AmosLewis AmosLewis commented Jan 20, 2023 •
edited
Loading

Find this error in nod-ai/SHARK-Studio#494
Deal with aten.view input -1
Split view and slice from this patch: #1768

@AmosLewis AmosLewis requested a review from ramiro050 January 20, 2023 09:03
@AmosLewis AmosLewis mentioned this pull request Jan 20, 2023
Closed
ramiro050
ramiro050 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than fixing formatting by running git clang-format, LGTM

lib/Conversion/TorchToTosa/TorchToTosa.cpp Outdated Show resolved Hide resolved
@AmosLewis AmosLewis merged commit c5ac42a into llvm:main Jan 20, 2023
@AmosLewis AmosLewis deleted the view branch January 20, 2023 19:57
gpetters94 pushed a commit to gpetters94/mlir-npcomp that referenced this pull request May 10, 2023
@gpetters94
[TOSA] Add aten.view shape -1 support (llvm#1815)
20e7922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramiro050 ramiro050 ramiro050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmosLewis @ramiro050