Fix empty tensor when select -1 #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ramiro050 Would you review this PR? Thanks. |
ramiro050
approved these changes
Jan 12, 2023
|
If everything is ok, would you please merge it for me? And I'll close the related issue. |
|
Merged. Thanks @li-plus and @ramiro050 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed issue #1764 by first converting the
startindex to non-negative value before calculating theendindex. The conversion is:start += int(start < 0) * dimSize. This can avoidendbeing 0 whenstartis -1.I also added a test case
SelectIntNegativeDimAndIndexStaticModule_basicthat did not pass in LINALG backend without this PR to prove the correctness of my implementation.