Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: manually update PyTorch version #1782

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

vivekkhandelwal1
Copy link
Collaborator

Set PyTorch and TorchVision version to nightly release 2023-01-08.

Signed-Off By: Vivek Khandelwal[email protected]

@ashay
Copy link
Collaborator

ashay commented Jan 9, 2023

It looks like no torchvision WHL was generated for Windows yesterday, but if you bump the version by one more day (torch==2.0.0.dev20230109, torchvision==0.15.0.dev20230109, hash=65ff52a53b468266f7fdd93069ff04532f4d002d), then the build will likely run smoothly.

@vivekkhandelwal1
Copy link
Collaborator Author

It looks like no torchvision WHL was generated for Windows yesterday, but if you bump the version by one more day (torch==2.0.0.dev20230109, torchvision==0.15.0.dev20230109, hash=65ff52a53b468266f7fdd93069ff04532f4d002d), then the build will likely run smoothly.

Thanks! I have updated the PR.

@vivekkhandelwal1 vivekkhandelwal1 requested a review from ashay January 9, 2023 14:14
@ashay
Copy link
Collaborator

ashay commented Jan 9, 2023

Dang, sorry, it looks we also need to run the ./build_tools/update_*.sh scripts.

@vivekkhandelwal1
Copy link
Collaborator Author

@ashay @silvasean Why is the CI checks not running completely?

@ashay
Copy link
Collaborator

ashay commented Jan 10, 2023

There's an assertion failure while running the TorchDynamo e2e tests:

python: /main_checkout/torch-mlir/lib/Dialect/Torch/Transforms/RefineTypes.cpp:1191: void (anonymous namespace)::TypeAnalysis::incorporateKnowledge(Value, const ValueKnowledge &): Assertion `updatedKnowledge.has_value() && "IR has contradictory type!"' failed.

It is strange that it's causing the GitHub workflow to hang instead of failing immediately.

@vivekkhandelwal1
Copy link
Collaborator Author

vivekkhandelwal1 commented Jan 10, 2023

There's an assertion failure while running the TorchDynamo e2e tests:

python: /main_checkout/torch-mlir/lib/Dialect/Torch/Transforms/RefineTypes.cpp:1191: void (anonymous namespace)::TypeAnalysis::incorporateKnowledge(Value, const ValueKnowledge &): Assertion `updatedKnowledge.has_value() && "IR has contradictory type!"' failed.

It is strange that it's causing the GitHub workflow to hang instead of failing immediately.

The culprit seems to me, MobilenetV3Module_basic. @silvasean Could you please take a look at this?

EDIT: Actually, RandnDtypeDeviceModule_basic is causing the error not mobile net. I have created the issue here: #1792.

Set PyTorch and TorchVision version to nightly release 2023-01-08.

Signed-Off By: Vivek Khandelwal<[email protected]>
@vivekkhandelwal1 vivekkhandelwal1 merged commit fd236b2 into llvm:main Jan 11, 2023
@vivekkhandelwal1 vivekkhandelwal1 deleted the roll-pytorch branch January 11, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants