Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLIR][TORCH] Add missing ops in RefineTypes.cpp #1745

Closed

Conversation

vivekkhandelwal1
Copy link
Collaborator

Signed-Off By: Vivek Khandelwal[email protected]

Copy link
Collaborator

@AmosLewis AmosLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmosLewis
Copy link
Collaborator

Related Issue: nod-ai/SHARK-Studio#494

Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed. These ops were removed from here to make sure the custom op code works:

def aten〇tanh〡dtype(self_rank: int, self_dtype: int) -> int:

From looking at the issue linked, it seems that the problem is that some places in the code base call getDtype without first checking hasDtype. The solution should be to add the right checks

@vivekkhandelwal1
Copy link
Collaborator Author

This should not be needed. These ops were removed from here to make sure the custom op code works:

def aten〇tanh〡dtype(self_rank: int, self_dtype: int) -> int:

From looking at the issue linked, it seems that the problem is that some places in the code base call getDtype without first checking hasDtype. The solution should be to add the right checks

Thanks for letting me know.

@vivekkhandelwal1 vivekkhandelwal1 deleted the fix-refine-types branch December 23, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants