Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] build: update llvm tag to 14212c96 #1268

Closed
wants to merge 1 commit into from
Closed

[draft] build: update llvm tag to 14212c96 #1268

wants to merge 1 commit into from

Conversation

ashay
Copy link
Collaborator

@ashay ashay commented Aug 23, 2022

Do not review yet, waiting for CI to pass.

Summary of changes:

Summary of changes:
 - Updated MHLO commit to build with LLVM commit hash 14212c9
 - Re-enabled two failing TOSA tests, thus resolving Github Issue #1231
 - Replace deprecated hasValue() with has_value()
   (https://reviews.llvm.org/D131349)
 - Fixed warnings from comparison between signed and unsigned values
@ashay
Copy link
Collaborator Author

ashay commented Aug 23, 2022

@fortianyou Any idea why the MHLO tests failing? Here's a portion of the stack trace from the assertion failure:

#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007ffff7c64537 in __GI_abort () at abort.c:79
#2  0x00007ffff7c6440f in __assert_fail_base (fmt=0x7ffff7dcd128 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x7fffc05ed7e0 "hasVal",
    file=0x7fffc11bec87 "torch-mlir/externals/llvm-project/llvm/include/llvm/ADT/Optional.h", line=215, function=<optimized out>)
    at assert.c:92
#3  0x00007ffff7c73662 in __GI___assert_fail (assertion=0x7fffc05ed7e0 "hasVal",
    file=0x7fffc11bec87 "torch-mlir/externals/llvm-project/llvm/include/llvm/ADT/Optional.h", line=215,
    function=0x7fffc09f6a1d "T &llvm::optional_detail::OptionalStorage<mlir::DenseElementsAttr, true>::value() & [T = mlir::DenseElementsAttr]")
    at assert.c:101
#4  0x00007fffc552b09b in mlir::mhlo::(anonymous namespace)::ConvolutionOpGeneralConversion::matchAndRewrite(mlir::mhlo::ConvolutionOp, mlir::mhlo::ConvolutionOpAdaptor, mlir::ConversionPatternRewriter&) const ()
   from torch-mlir/build/tools/torch-mlir/python_packages/torch_mlir/torch_mlir/_mlir_libs/libTorchMLIRAggregateCAPI.so
#5  0x00007fffc552053b in mlir::OpConversionPattern<mlir::mhlo::ConvolutionOp>::matchAndRewrite(mlir::Operation*, llvm::ArrayRef<mlir::Value>, mlir::ConversionPatternRewriter&) const ()
   from torch-mlir/build/tools/torch-mlir/python_packages/torch_mlir/torch_mlir/_mlir_libs/libTorchMLIRAggregateCAPI.so

The error can be reproduced by running python3 -m e2e_testing.torchscript.main --config=mhlo -v -s, although the individual test python3 -m e2e_testing.torchscript.main --config=mhlo -v --filter=AdaptiveAvgPool2dUnitOutputSizeStaticModule_basic passes.

@ashay
Copy link
Collaborator Author

ashay commented Aug 28, 2022

Closing, since I will attempt a new LLVM merge tomorrow (Monday) morning.

@ashay ashay closed this Aug 28, 2022
@ashay ashay deleted the ashay/llvm-tag-update branch August 28, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant