-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll Torch-MLIR_Architecture.png into main diagram #1265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "backend contract" box is super important for the architecture.md use of Torch-MLIR_Architecture.png, but probably not for the README. I think these two diagrams (README and architecture.md) have two slightly different target audiences, so let's keep them as separate files for now.
Also, the Torch dialect is actually used throughout the "purple" boxes in the Torch-MLIR "frontend". It is really deceptive to have it only in the backend.
Overall I think the original diagram is really good, and we just need to remove the torch_dispatch and replace Torch-MLIR Dialct with "Torch Dialect".
Add MHLO and Custom dialects
3fa9969
to
232c518
Compare
Updated per @silvasean comment. PTAL |
I don't think this was removed in the commit you just force pushed @powderluv . I believe we do want to remove the torch_dispatch path:
|
Ah ok. I missed the first part. Thanks for fixing in the follow on |
* add Krnl Ops Signed-off-by: chentong319 <[email protected]> * lowering Signed-off-by: chentong319 <[email protected]> * test Signed-off-by: chentong319 <[email protected]> * fix makefile Signed-off-by: chentong319 <[email protected]> * format Signed-off-by: chentong319 <[email protected]> * format Signed-off-by: chentong319 <[email protected]> Co-authored-by: Tung D. Le <[email protected]>
Update all references to
torch
dialectRoll the Torch-MLIR_Architecture.png contents into main diagram
Remove torch_dispatch() which was originally FX lowering