Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update llvm tag to e5d51463 #1263

Closed
wants to merge 1 commit into from
Closed

build: update llvm tag to e5d51463 #1263

wants to merge 1 commit into from

Conversation

ashay
Copy link
Collaborator

@ashay ashay commented Aug 22, 2022

Summary of changes:

Summary of changes:
 - Updated MHLO commit to build with LLVM commit has e5d5146
 - Re-enabled two failing TOSA tests, thus resolving Github Issue #1231
 - Replace deprecated hasValue() with has_value()
   (https://reviews.llvm.org/D131349)
Copy link

@sstamenova sstamenova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@powderluv
Copy link
Collaborator

thank you.

@ashay
Copy link
Collaborator Author

ashay commented Aug 22, 2022

Dang, upstream LLVM on macOS arm64 was broken (see CI log) but it was fixed in a later commit. I'll wait until tonight's (internal) CI run to get a new green LLVM commit and try another Torch-MLIR update tomorrow.

@ashay ashay closed this Aug 22, 2022
@ashay ashay deleted the ashay/llvm-tag-update branch August 22, 2022 22:10
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
…tor code (llvm#1263)

* Do not use NNPA preprocessor to avoid exposing accelerator code

Signed-off-by: Tung D. Le <[email protected]>

* clang-format

Signed-off-by: Tung D. Le <[email protected]>

* Move OptimizationLevel to the common place

Signed-off-by: Tung D. Le <[email protected]>

* Rename functions

Signed-off-by: Tung D. Le <[email protected]>

* format

Signed-off-by: Tung D. Le <[email protected]>

* Address comments

Signed-off-by: Tung D. Le <[email protected]>
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
…ums (llvm#1261)

* [maccel]: Change --maccel option from a string option to a list of enums

Signed-off-by: Ettore Tiotto <[email protected]>
Signed-off-by: Tung D. Le <[email protected]>

* - add queryEntryPoints Java API (llvm#1255)

- use GENERATE_NATIVE_HEADERS option of add_jar (require
  cmake 3.11+) to generate JNI header since javah was
  deprecated since Java 8

Signed-off-by: Gong Su <[email protected]>
Signed-off-by: Tung D. Le <[email protected]>

* Do not set ownership for an output OMTensor that is also a block argument (llvm#1256)

* Do not set ownership for an output that is also a block argument

Signed-off-by: Tung D. Le <[email protected]>

* Edit lit tests

Signed-off-by: Tung D. Le <[email protected]>

* More name changes

Signed-off-by: Tung D. Le <[email protected]>

* Edit comments

Signed-off-by: Tung D. Le <[email protected]>

* typos

Signed-off-by: Tung D. Le <[email protected]>

* Make the llvm.ident lit test more meaningful (llvm#1260)

* Make the llvm.ident lit test more meaningful

Update the test to specifically look for a commit hash instead of any characters

Signed-off-by: Stella Stamenova <[email protected]>

* Account for .git suffix

Signed-off-by: Stella Stamenova <[email protected]>

Co-authored-by: Tung D. Le <[email protected]>
Signed-off-by: Tung D. Le <[email protected]>

* [backend_cpp]: Use ModelLib to create CategoryMapper cpp tests.

Signed-off-by: Ettore Tiotto <[email protected]>
Signed-off-by: Tung D. Le <[email protected]>

* Revert "[backend_cpp]: Use ModelLib to create CategoryMapper cpp tests."

This reverts commit 00e8a6bdd6d90c6125326173340fd3e00f9c838c.

Signed-off-by: Tung D. Le <[email protected]>

* [Accelerator] Do not use NNPA preprocessor to avoid exposing accelerator code (llvm#1263)

* Do not use NNPA preprocessor to avoid exposing accelerator code

Signed-off-by: Tung D. Le <[email protected]>

* clang-format

Signed-off-by: Tung D. Le <[email protected]>

* Move OptimizationLevel to the common place

Signed-off-by: Tung D. Le <[email protected]>

* Rename functions

Signed-off-by: Tung D. Le <[email protected]>

* format

Signed-off-by: Tung D. Le <[email protected]>

* Address comments

Signed-off-by: Tung D. Le <[email protected]>

* generate Accelerator option enum from CMake

Signed-off-by: Kevin O'Brien <[email protected]>
Signed-off-by: Tung D. Le <[email protected]>

* Edit CMakeLists.txt

Signed-off-by: Tung D. Le <[email protected]>

* clang-format

Signed-off-by: Tung D. Le <[email protected]>

Co-authored-by: gongsu832 <[email protected]>
Co-authored-by: Tung D. Le <[email protected]>
Co-authored-by: Stella Stamenova <[email protected]>
Co-authored-by: Kevin O'Brien <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants