Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bazel] Check cache directory exists before changing owners #1241

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

sjain-stanford
Copy link
Member

@sjain-stanford sjain-stanford commented Aug 17, 2022

This fixes a seeding issue with the previous PR where bazel build's GHA cache is not present to begin with and one of the commands (chown) fails on it. Should get the Bazel build back to green.

@sjain-stanford
Copy link
Member Author

sjain-stanford commented Aug 18, 2022

Co-incidentally, there's another failure after the rebase to develop (after this commit):

bazel-out/k8-fastbuild/bin/external/torch-mlir/_objs/TorchMLIRTorchPasses/Passes.pic.o:Passes.cpp:function
(anonymous namespace)::registerLowerToBackendContractPass()::{lambda()#1}::operator()()
const: error: undefined reference to 'mlir::torch::Torch::createLowerToBackendContractPass(int, bool)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Let me land this now, and send a follow-on PR to include "lib/Dialect/Torch/Transforms/LowerToBackendContract.cpp", to the TorchMLIRTorchPasses target.

@sjain-stanford sjain-stanford merged commit 114f48e into main Aug 18, 2022
@sjain-stanford sjain-stanford deleted the sambhav/bazel_in_docker branch August 18, 2022 00:06
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
Signed-off-by: Ian Bearman <[email protected]>

Co-authored-by: Tung D. Le <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants