-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decomposition for aten.roll #1170
Conversation
1840707
to
01c9c68
Compare
@fortianyou Please add an e2e example. |
01c9c68
to
8e9a7ec
Compare
Hey MHLO folks, before you add too many new ops, can you please plug in the MHLO backend into the end-to-end tests in our CI? More info here: #1025 (comment) I'm really worried about adding many new ops without our e2e tests. |
Thanks for reminding me @silvasean. I will try to figure out how to add the e2e tests for MHLO in Torch-MLIR CI. But the PR only added codes to decomposition, and I tried to add e2e UT in the lowering pass of linalg-on-tensors |
@pashu123 Can you have a glance at my code? Why is the data type of |
You will have to add the out type in refine types pass.
|
6a27099
to
a5add21
Compare
a5add21
to
18961d2
Compare
@pashu123 @silvasean After rebasing the latest main branch codes, all the tests are passed. Do you have any other comments? |
LGTM! Please make sure to squash all your commits before merging. |
aten.roll
to torch_ods_gen.py