Rename TorchToStd pass as TorchToArith #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! |
silvasean
approved these changes
Aug 5, 2022
|
Is there a protocol to merging ? I'm assuming once approved by someone with adequate reviewing powers we are ok merging ? Ramana |
|
Yes, go ahead and merge after it is marked "approved" on github and all comments are addressed. |
All the converters in this pass appear to create ops from the arith dialect. Hence the full rename. Fix GH Issue llvm#409.
u99127
pushed a commit
to u99127/torch-mlir
that referenced
this pull request
Aug 10, 2022
The CI didn't catch the missing rename of TorchToArith until the merge had happened. This is following up from llvm#1163
sjain-stanford
pushed a commit
that referenced
this pull request
Aug 10, 2022
The CI didn't catch the missing rename of TorchToArith until the merge had happened. This is following up from #1163
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
* ExecutionSession constructor without entry function name Signed-off-by: Tung D. Le <[email protected]> * clang-format Signed-off-by: Tung D. Le <[email protected]> * Do not use run_main_graph in ExecutionSession Signed-off-by: Tung D. Le <[email protected]> * Revise Signed-off-by: Tung D. Le <[email protected]> * Add omEntryPointName to pass Windows CI Signed-off-by: Tung D. Le <[email protected]> * Address review comments Signed-off-by: Tung D. Le <[email protected]> * Use run_main_graph as the default entry point Signed-off-by: Tung D. Le <[email protected]> * undo numerical.def Signed-off-by: Tung D. Le <[email protected]> * Change messages Signed-off-by: Tung D. Le <[email protected]> Co-authored-by: Alexandre Eichenberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the TorchToStd pass as TorchToArith. Unable to find the suitable unicode character as on the ticket :)
A quick read through the converters in this pass appear to create ops from the arith dialect. Hence the full rename.
Fix GH Issue #409.
@sjarus , @silvasean