Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cache-suffix name bug #1138

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Fix cache-suffix name bug #1138

merged 1 commit into from
Aug 3, 2022

Conversation

powderluv
Copy link
Collaborator

This should enabling better caching of builds.

@powderluv
Fix cache-suffix name bug
11dcf3f 
This should enabling better caching of builds.
makslevental
makslevental reviewed Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@makslevental makslevental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@powderluv
Copy link
Collaborator Author

Do you know what would cause

PASS - "_SoftmaxModule_basic"

Unexpected outcome summary:

****** Failed tests - 1 tests
    FAIL - "Matmul_vecmat"
        @ trace item #0 - call to "forward"
        @ output of call to "forward"
        ERROR: shape (torch.Size([1, 5])) is not equal to golden shape (torch.Size([5]))


Summary:
    Passed: 653
    Failed: 1

In the eager mode tests ?

@makslevental
Copy link
Collaborator

Do you know what would cause

PASS - "_SoftmaxModule_basic"

Unexpected outcome summary:

****** Failed tests - 1 tests
    FAIL - "Matmul_vecmat"
        @ trace item #0 - call to "forward"
        @ output of call to "forward"
        ERROR: shape (torch.Size([1, 5])) is not equal to golden shape (torch.Size([5]))


Summary:
    Passed: 653
    Failed: 1

In the eager mode tests ?

@powderluv

I expect some type system shenanigans symbolic trace sees a d element vector but it actually gets turned into a 1*d matrix for this particular op. Will take a look soon.

@powderluv
Copy link
Collaborator Author

CI fix has landed on master.

@powderluv powderluv merged commit 0d25b6f into main Aug 3, 2022
@powderluv powderluv deleted the powderluv-fix-cache-suffix branch August 3, 2022 14:53
@tanyokwok tanyokwok mentioned this pull request Sep 21, 2022
Closed
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
@AlexandreEichenberger
Benchmarking: first step, reusing code in numerical for building/comp…
9f4b861 
…iling models (llvm#1138)

Move out of test/numerical the code that generate an ONNX graph and compile it. This code is now in test/modellib. It can then be reused by other benchmarks testing for performance.

Signed-off-by: Alexandre Eichenberger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makslevental makslevental makslevental left review comments

@silvasean silvasean Awaiting requested review from silvasean

@pashu123 pashu123 Awaiting requested review from pashu123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@powderluv @makslevental