Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MHLO] Init MHLO reduce-like op conversion #1133

Merged

Conversation

Vremold
Copy link
Collaborator

@Vremold Vremold commented Aug 2, 2022

See RFC #999

Co-authored-by: Bairen Yi [email protected]
Co-authored-by: Jiawei Wu [email protected]
Co-authored-by: Tianyou Guo [email protected]
Co-authored-by: Xu Yan [email protected]
Co-authored-by: Ziheng Jiang [email protected]

@Vremold Vremold changed the title Init MHLO reduce-like op conversion [MHLO] Init MHLO reduce-like op conversion Aug 2, 2022
Vremold added 2 commits August 2, 2022 18:05
Co-authored-by: Bairen Yi <[email protected]>
Co-authored-by: Jiawei Wu <[email protected]>
Co-authored-by: Tianyou Guo <[email protected]>
Co-authored-by: Xu Yan <[email protected]>
Co-authored-by: Ziheng Jiang <[email protected]>
@Vremold Vremold force-pushed the upstream-05-init-mhlo-reduction-op-conversion branch from 0f075c8 to 7797317 Compare August 2, 2022 10:14
Copy link
Member

@jpienaar jpienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just some drive by comments.

lib/Conversion/TorchToMhlo/ReductionOp.cpp Outdated Show resolved Hide resolved
lib/Conversion/TorchToMhlo/ReductionOp.cpp Show resolved Hide resolved
lib/Conversion/TorchToMhlo/ReductionOp.cpp Outdated Show resolved Hide resolved
lib/Conversion/TorchToMhlo/ReductionOp.cpp Outdated Show resolved Hide resolved
lib/Conversion/TorchToMhlo/ReductionOp.cpp Outdated Show resolved Hide resolved
lib/Conversion/TorchToMhlo/ReductionOp.cpp Show resolved Hide resolved
@Vremold
Copy link
Collaborator Author

Vremold commented Aug 2, 2022

Ready for review. @silvasean @fortianyou @ZihengJiang @Yancey1989

@Vremold
Copy link
Collaborator Author

Vremold commented Aug 2, 2022

Nice, just some drive by comments.

Thanks for your useful suggestions. We will fix these in later commit!

@Vremold Vremold force-pushed the upstream-05-init-mhlo-reduction-op-conversion branch from 7797317 to 2156a26 Compare August 2, 2022 14:46
@Vremold Vremold force-pushed the upstream-05-init-mhlo-reduction-op-conversion branch from 2156a26 to f5b6dcc Compare August 2, 2022 14:56
Copy link
Collaborator

@ZihengJiang ZihengJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vremold Vremold merged commit 636f5ac into llvm:main Aug 3, 2022
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
Signed-off-by: ian Bearman <[email protected]>

Co-authored-by: Alexandre Eichenberger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants