Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add embedding Bag e2e case in xfail set #1130

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

vidsinghal
Copy link
Collaborator

No description provided.

@vidsinghal vidsinghal requested a review from ramiro050 August 1, 2022 21:37
@vidsinghal vidsinghal force-pushed the embedding_bag_xfail branch 2 times, most recently from c4d6ff2 to 9af3fe3 Compare August 1, 2022 21:47
Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename the commit to match the changes? Other than that, it LGTM! Feel free to merge after the CI passes

@vidsinghal vidsinghal force-pushed the embedding_bag_xfail branch from 9af3fe3 to 4370d64 Compare August 1, 2022 21:59
@vidsinghal
Copy link
Collaborator Author

Can you rename the commit to match the changes? Other than that, it LGTM! Feel free to merge after the CI passes

cool, completed!

@vidsinghal vidsinghal merged commit fe3c9f5 into llvm:main Aug 1, 2022
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
Codegen for CategoryMapper
Signed-off-by: Ettore Tiotto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants