Add support for releasing windows wheels. #2
Conversation
|
Hello @stellaraccident and @sjain-stanford I am hoping to enable windows python wheel releases for |
|
Thanks. I don't have any concerns as long as you (or someone) is willing to support in keeping this "green" going forward. Looping in @saienduri and @stellaraccident as well in case they have thoughts. |
|
Thanks, yes I intend to keep maintaining the windows wheels. |
| name: Build Release and Publish windows wheels | ||
|
|
||
| on: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
can you add a pull_request: temporarily here? This will trigger a run and that way we can see how long it takes and if it works as intended :)
There was a problem hiding this comment.
Thanks for the review @saienduri. I've made the suggested edit but I don't have permission to run the workflow. Can you trigger it please when you get a chance? Thanks!
There was a problem hiding this comment.
Thanks @saienduri, looks like it failed due to permissions probably because this is triggered via the PR. The action does run fine in my repo https://github.com/sahas3/torch-mlir-release/actions/runs/11487806632. To debug further, I made a temporary change to elevate all permissions but I can't trigger the workflow myself. What will be best way to debug this further in this repo -- any suggestions?
There was a problem hiding this comment.
I recently got write access to LLVM but looks like that doesn't cover this repository, so I still cannot trigger the workflow in here to debug the issue further. Is it possible to get write access for this repository? If not, @saienduri do you have any suggestions for debugging the permission issue as the change runs fine in my forked repo. Thanks!
There was a problem hiding this comment.
I don't think the GITHUB_TOKEN itself is accessible on forks. You can revert your permission change and we can land.
There was a problem hiding this comment.
Thanks @saienduri. Reverted the temporary changes.
There was a problem hiding this comment.
Thanks @saienduri, can you please merge this PR as well whenever you get a chance.
There was a problem hiding this comment.
Testing if it works here @sahas3: https://github.com/llvm/torch-mlir-release/actions/runs/11960219589
|
Thanks, great to see windows wheels! |
|
No opinion on this, but we should re enable the windows CI on the main project, at least in terms of building. We can do that with the jit importer and stablehlo disabled since they do not seem to get timely windows updates. |
I can take a stab at this. Are you suggesting to run the windows CI build for each PR change similar to the linux CI? |
This PR adds support for windows nightly build for releasing
torch-mlirpython wheels following the work done for linux.Here's the job for the windows build: https://github.com/sahas3/torch-mlir-release/actions/runs/11425775316