Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlir][test] Add comments in a test (nfc) #99810

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

banach-space
Copy link
Contributor

@banach-space banach-space commented Jul 21, 2024

Documents which patterns are tested in:

  • vector-transfer-collapse-inner-most-dims.mlir.

Adds a note to document which patterns are tested in
  * vector-transfer-collapse-inner-most-dims.mlir.
@llvmbot
Copy link
Member

llvmbot commented Jul 21, 2024

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-vector

Author: Andrzej Warzyński (banach-space)

Changes

Adds a note to document which patterns are tested in

  • vector-transfer-collapse-inner-most-dims.mlir.

Full diff: https://github.com/llvm/llvm-project/pull/99810.diff

1 Files Affected:

  • (modified) mlir/test/Dialect/Vector/vector-transfer-collapse-inner-most-dims.mlir (+2)
diff --git a/mlir/test/Dialect/Vector/vector-transfer-collapse-inner-most-dims.mlir b/mlir/test/Dialect/Vector/vector-transfer-collapse-inner-most-dims.mlir
index 3f36756fe95d7..cd56c1bf9695b 100644
--- a/mlir/test/Dialect/Vector/vector-transfer-collapse-inner-most-dims.mlir
+++ b/mlir/test/Dialect/Vector/vector-transfer-collapse-inner-most-dims.mlir
@@ -2,6 +2,7 @@
 
 //-----------------------------------------------------------------------------
 // 1. vector.transfer_read
+// [Pattern: DropInnerMostUnitDimsTransferRead]
 //-----------------------------------------------------------------------------
 
 func.func @contiguous_inner_most(%src: memref<1x1x8x1xf32, strided<[3072, 8, 1, 1], offset: ?>>) -> vector<1x8x1xf32>{
@@ -306,6 +307,7 @@ func.func @negative_non_unit_strides(%src: memref<512x16x1xf32, strided<[8192, 1
 
 //-----------------------------------------------------------------------------
 // 2. vector.transfer_write
+// [Pattern: DropInnerMostUnitDimsTransferWrite]
 //-----------------------------------------------------------------------------
 
 func.func @contiguous_inner_most(%dest: memref<1x512x16x1x1xf32>, %v: vector<1x16x16x1x1xf32>, %i: index) {

Copy link
Member

@jpienaar jpienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me wonder if we could almost do something automated (with debugging enabled the patterns are reported, per function getting the patterns that applied as post processing should be doable)

@banach-space
Copy link
Contributor Author

This makes me wonder if we could almost do something automated (with debugging enabled the patterns are reported, per function getting the patterns that applied as post processing should be doable)

Funnily enough, it's the -debug dump that I got the pattern names from. But I'd need some quality time with the pattern rewriter driver (or pointers from sb) to implement a dedicated options for this (e.g. -debug-list-successeful-patterns). Thanks for +1!

@banach-space banach-space merged commit 14a543e into llvm:main Jul 21, 2024
11 checks passed
sgundapa pushed a commit to sgundapa/upstream_effort that referenced this pull request Jul 23, 2024
Documents which patterns are tested in:
  * vector-transfer-collapse-inner-most-dims.mlir.
@banach-space banach-space deleted the andrzej/add_comment branch July 25, 2024 11:39
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
Summary:
Documents which patterns are tested in:
  * vector-transfer-collapse-inner-most-dims.mlir.

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants