[llvm-cov][CoverageView] minor fix/improvement to HTML and text coverage output

[whentojump]

1. add the missing condition for MC/DC in hasSubViews()
2. add style for selected line
3. remove name="Ln" attribute in the link within MC/DC views
4. remove color for \n

@evodius96 Comments are appreciated!

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[whentojump]

I can confirm these commits are breaking two tests, and specifically the HTML part:

  LLVM :: tools/llvm-cov/mcdc-general-none.test
  LLVM :: tools/llvm-cov/mcdc-general.test

I'll investigate and update tests if that's the reason for failure.

[whentojump]

The tests should have be fixed.

Basically change the expected HTML output accordingly (due to commit [llvm-cov][CoverageViewHTML] remove name="Ln" attribute in the link within MC/DC views) and remove the name attribute as well

[evodius96]

LGTM -- thanks for catching these. It would be great if you could backport this to the 18.x branch.

[whentojump]

if you could backport this to the 18.x branch.

Yes I'm happy to.

I don't know the procedures well. To my preliminary understanding: first let's wait for this one to get merged into main; then I interact with @llvmbot here or somewhere else to do the backport. Is that right?

[evodius96]

if you could backport this to the 18.x branch.

Yes I'm happy to.

I don't know the procedures well. To my preliminary understanding: first let's wait for this one to get merged into main; then I interact with @llvmbot here or somewhere else to do the backport. Is that right?

Yes, I think you can follow the steps outlined here: https://llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches

[whentojump]

A gentle bump for more comments. (Which members are the best to include?)

By the way, @evodius96 do you have plans of updating this page https://llvm.org/docs/CoverageMappingFormat.html ? We probably want to include the changes since version 6. I can also do a draft for that. Also could you please take a look at #80531? Much appreciated!

[evodius96]

A gentle bump for more comments. (Which members are the best to include?)

Your fix is minor and straightforward; I don't see the need for additional reviewers, but it's not a problem.

By the way, @evodius96 do you have plans of updating this page https://llvm.org/docs/CoverageMappingFormat.html ? We probably want to include the changes since version 6. I can also do a draft for that.

You're right -- the document needs to be updated for version 7. I did add information about the Decision mapping region in the Mapping Region section, but the discussion of what changed between version 6 and 7 also needs to mention that. If you want to draft that change, that's OK with me.

Also could you please take a look at #80531?

I can take a look, but it does look like you have the right reviewers on it.