Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NVPTX] Improve lowering of v2i16 logical ops. #67073

Merged
merged 1 commit into from
Sep 22, 2023
Merged

[NVPTX] Improve lowering of v2i16 logical ops. #67073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,10 +642,9 @@ NVPTXTargetLowering::NVPTXTargetLowering(const NVPTXTargetMachine &TM,
setI16x2OperationAction(ISD::UREM, MVT::v2i16, Legal, Custom);

// Other arithmetic and logic ops are unsupported.
setOperationAction({ISD::AND, ISD::OR, ISD::XOR, ISD::SDIV, ISD::UDIV,
ISD::SRA, ISD::SRL, ISD::MULHS, ISD::MULHU,
ISD::FP_TO_SINT, ISD::FP_TO_UINT, ISD::SINT_TO_FP,
ISD::UINT_TO_FP},
setOperationAction({ISD::SDIV, ISD::UDIV, ISD::SRA, ISD::SRL, ISD::MULHS,
ISD::MULHU, ISD::FP_TO_SINT, ISD::FP_TO_UINT,
ISD::SINT_TO_FP, ISD::UINT_TO_FP},
MVT::v2i16, Expand);

setOperationAction(ISD::ADDC, MVT::i32, Legal);
Expand Down
11 changes: 11 additions & 0 deletions llvm/lib/Target/NVPTX/NVPTXInstrInfo.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,6 +1486,17 @@ defm OR : BITWISE<"or", or>;
defm AND : BITWISE<"and", and>;
defm XOR : BITWISE<"xor", xor>;

// Lower logical ops as bitwise ops on b32.
// By this point the constants get legalized into a bitcast from i32, so that's
// what we need to match here.
def: Pat<(or Int32Regs:$a, (v2i16 (bitconvert (i32 imm:$b)))),
(ORb32ri Int32Regs:$a, imm:$b)>;
def: Pat<(xor Int32Regs:$a, (v2i16 (bitconvert (i32 imm:$b)))),
(XORb32ri Int32Regs:$a, imm:$b)>;
def: Pat<(and Int32Regs:$a, (v2i16 (bitconvert (i32 imm:$b)))),
(ANDb32ri Int32Regs:$a, imm:$b)>;


def NOT1 : NVPTXInst<(outs Int1Regs:$dst), (ins Int1Regs:$src),
"not.pred \t$dst, $src;",
[(set Int1Regs:$dst, (not Int1Regs:$src))]>;
Expand Down
64 changes: 64 additions & 0 deletions llvm/test/CodeGen/NVPTX/i16x2-instructions.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,70 @@ define <2 x i16> @test_mul(<2 x i16> %a, <2 x i16> %b) #0 {
ret <2 x i16> %r
}

;; Logical ops are available on all GPUs as regular 32-bit logical ops
; COMMON-LABEL: test_or(
; COMMON-DAG: ld.param.u32 [[A:%r[0-9]+]], [test_or_param_0];
; COMMON-DAG: ld.param.u32 [[B:%r[0-9]+]], [test_or_param_1];
; COMMON-NEXT: or.b32 [[R:%r[0-9]+]], [[A]], [[B]];
; COMMON-NEXT: st.param.b32 [func_retval0+0], [[R]];
; COMMON-NEXT: ret;
define <2 x i16> @test_or(<2 x i16> %a, <2 x i16> %b) #0 {
%r = or <2 x i16> %a, %b
ret <2 x i16> %r
}

; Check that we can lower or with immediate arguments.
; COMMON-LABEL: test_or_imm_0(
; COMMON-DAG: ld.param.u32 [[A:%r[0-9]+]], [test_or_imm_0_param_0];
; COMMON-NEXT: or.b32 [[R:%r[0-9]+]], [[A]], 131073;
; COMMON-NEXT: st.param.b32 [func_retval0+0], [[R]];
; COMMON-NEXT: ret;
define <2 x i16> @test_or_imm_0(<2 x i16> %a) #0 {
%r = or <2 x i16> <i16 1, i16 2>, %a
ret <2 x i16> %r
}

; COMMON-LABEL: test_or_imm_1(
; COMMON-DAG: ld.param.u32 [[B:%r[0-9]+]], [test_or_imm_1_param_0];
; COMMON-NEXT: or.b32 [[R:%r[0-9]+]], [[A]], 131073;
; COMMON-NEXT: st.param.b32 [func_retval0+0], [[R]];
; COMMON-NEXT: ret;
define <2 x i16> @test_or_imm_1(<2 x i16> %a) #0 {
%r = or <2 x i16> %a, <i16 1, i16 2>
ret <2 x i16> %r
}

; COMMON-LABEL: test_xor(
; COMMON-DAG: ld.param.u32 [[A:%r[0-9]+]], [test_xor_param_0];
; COMMON-DAG: ld.param.u32 [[B:%r[0-9]+]], [test_xor_param_1];
; COMMON-NEXT: xor.b32 [[R:%r[0-9]+]], [[A]], [[B]];
; COMMON-NEXT: st.param.b32 [func_retval0+0], [[R]];
; COMMON-NEXT: ret;
define <2 x i16> @test_xor(<2 x i16> %a, <2 x i16> %b) #0 {
%r = xor <2 x i16> %a, %b
ret <2 x i16> %r
}

; Check that we can lower xor with immediate arguments.
; COMMON-LABEL: test_xor_imm_0(
; COMMON-DAG: ld.param.u32 [[A:%r[0-9]+]], [test_xor_imm_0_param_0];
; COMMON-NEXT: xor.b32 [[R:%r[0-9]+]], [[A]], 131073;
; COMMON-NEXT: st.param.b32 [func_retval0+0], [[R]];
; COMMON-NEXT: ret;
define <2 x i16> @test_xor_imm_0(<2 x i16> %a) #0 {
%r = xor <2 x i16> <i16 1, i16 2>, %a
ret <2 x i16> %r
}

; COMMON-LABEL: test_xor_imm_1(
; COMMON-DAG: ld.param.u32 [[B:%r[0-9]+]], [test_xor_imm_1_param_0];
; COMMON-NEXT: xor.b32 [[R:%r[0-9]+]], [[A]], 131073;
; COMMON-NEXT: st.param.b32 [func_retval0+0], [[R]];
; COMMON-NEXT: ret;
define <2 x i16> @test_xor_imm_1(<2 x i16> %a) #0 {
%r = xor <2 x i16> %a, <i16 1, i16 2>
ret <2 x i16> %r
}

; COMMON-LABEL: .func test_ldst_v2i16(
; COMMON-DAG: ld.param.u64 [[A:%rd[0-9]+]], [test_ldst_v2i16_param_0];
Expand Down