Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mlir][Vector] NFC - Fix doc generation #67007

Merged
merged 1 commit into from
Sep 21, 2023
Merged

[mlir][Vector] NFC - Fix doc generation #67007

merged 1 commit into from
Sep 21, 2023

Conversation

nicolasvasilache
Copy link
Contributor

No description provided.

@nicolasvasilache
Copy link
Contributor Author

I verified that cat build/tools/mlir/docs/Dialects/Vector.md now gets populated with the ops when using cmake --target mlir-doc but I am unclear if this is properly linked in the website.

Does anyone know how to test that or are we essentially flying blind until we get it right ?

@c-rhodes
Copy link
Collaborator

I verified that cat build/tools/mlir/docs/Dialects/Vector.md now gets populated with the ops when using cmake --target mlir-doc but I am unclear if this is properly linked in the website.

Fix makes sense to me, Vector.md includes auto-generated VectorOps.md and the ops are being generated there again.

Does anyone know how to test that or are we essentially flying blind until we get it right ?

It's documented here https://github.com/llvm/mlir-www/blob/main/README.md but it's a bit of a process.

c-rhodes
c-rhodes approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@c-rhodes c-rhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cheers

@nicolasvasilache nicolasvasilache merged commit 3b0f812 into llvm:main Sep 21, 2023
@nicolasvasilache nicolasvasilache deleted the vector-ops-doc branch September 21, 2023 13:11
@MacDue
Copy link
Member

MacDue commented Sep 22, 2023

This seems not to have worked https://mlir.llvm.org/docs/Dialects/Vector/ is still missing all the op docs.

@kstoimenov kstoimenov mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-rhodes c-rhodes c-rhodes approved these changes

Assignees
No one assigned
Labels
mlir:vector mlir:vectorops mlir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolasvasilache @c-rhodes @MacDue @llvmbot