Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InstrRef][NFC] Improve diagram illustrating locations #66944

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

felipepiovezan
Copy link
Contributor

The "register number" arrow should point to LocationID, not LocIdx.

The "register number" arrow should point to `LocationID`, not `LocIdx`.
@llvmbot
Copy link
Member

llvmbot commented Sep 20, 2023

@llvm/pr-subscribers-debuginfo

Changes

The "register number" arrow should point to LocationID, not LocIdx.


Full diff: https://github.com/llvm/llvm-project/pull/66944.diff

1 Files Affected:

  • (modified) llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h (+2-2)
diff --git a/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h b/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
index 30de18e53c4fb43..5e94962f9d7e648 100644
--- a/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
+++ b/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
@@ -602,8 +602,8 @@ class LocIdxToIndexFunctor {
 /// Slot Num (%stack.0)   /
 /// FrameIdx => SpillNum /
 ///              \      /
-///           SpillID (int)              Register number (int)
-///                      \                  /
+///           SpillID (int)   Register number (int)
+///                      \       /
 ///                      LocationID => LocIdx
 ///                                |
 ///                       LocIdx => ValueIDNum

Copy link
Member

@jmorse jmorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (cheers for spotting!)

@felipepiovezan felipepiovezan merged commit ec1d811 into llvm:main Sep 22, 2023
@felipepiovezan felipepiovezan deleted the felipe/update_comment branch September 22, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants