[MLIR][Presburger] Template Matrix to allow MPInt and Fraction and separate out IntMatrix #66897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstantiation Duplicate makeMatrix to makeIntMatrix and makeFracMatrix Implement arithmetic operations for Fraction for compatibility
…nstantiation Duplicate makeMatrix to makeIntMatrix and makeFracMatrix Implement arithmetic operations for Fraction for compatibility
This reverts commit 2871b0127a3cbc8d2a4cf294e731aade1ed56424.
…nstantiation Duplicate makeMatrix to makeIntMatrix and makeFracMatrix Implement arithmetic operations for Fraction for compatibility
…nstantiation Duplicate makeMatrix to makeIntMatrix and makeFracMatrix Implement arithmetic operations for Fraction for compatibility
Superty
reviewed
Sep 20, 2023
This was referenced Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matrix has been templated to Matrix (for MPInt and Fraction) with explicit instantiation for both these types.
IntMatrix, inheriting from Matrix, has been created to allow for integer-only methods.
makeMatrix has been duplicated to makeIntMatrix and makeFracMatrix.
This was already landed previously but was reverted in 98c994c due to build failure. This fixes the failure.