-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RISCV] Update Zicntr and Zihpm to version 2p0 #66323
Conversation
@llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-risc-v ChangesNone -- Full diff: https://github.com//pull/66323.diff4 Files Affected:
diff --git a/clang/test/Preprocessor/riscv-target-features.c b/clang/test/Preprocessor/riscv-target-features.c index 02b67dc7944ba88..8cdd23a927e3c80 100644 --- a/clang/test/Preprocessor/riscv-target-features.c +++ b/clang/test/Preprocessor/riscv-target-features.c @@ -643,7 +643,7 @@ // RUN: %clang -target riscv64-unknown-linux-gnu \ // RUN: -march=rv64izicntr -x c -E -dM %s \ // RUN: -o - | FileCheck --check-prefix=CHECK-ZICNTR-EXT %s -// CHECK-ZICNTR-EXT: __riscv_zicntr 1000000{{$}} +// CHECK-ZICNTR-EXT: __riscv_zicntr 2000000{{$}} // RUN: %clang -target riscv32-unknown-linux-gnu \ // RUN: -march=rv32izicsr2p0 -x c -E -dM %s \ @@ -677,6 +677,14 @@ // RUN: -o - | FileCheck --check-prefix=CHECK-ZIHINTPAUSE-EXT %s // CHECK-ZIHINTPAUSE-EXT: __riscv_zihintpause 2000000{{$}} +// RUN: %clang -target riscv32-unknown-linux-gnu \ +// RUN: -march=rv32izihpm -x c -E -dM %s \ +// RUN: -o - | FileCheck --check-prefix=CHECK-ZIHPM-EXT %s +// RUN: %clang -target riscv64-unknown-linux-gnu \ +// RUN: -march=rv64izihpm -x c -E -dM %s \ +// RUN: -o - | FileCheck --check-prefix=CHECK-ZIHPM-EXT %s +// CHECK-ZIHPM-EXT: __riscv_zihpm 2000000{{$}} + // RUN: %clang -target riscv32-unknown-linux-gnu \ // RUN: -march=rv32izk1p0 -x c -E -dM %s \ // RUN: -o - | FileCheck --check-prefix=CHECK-ZK-EXT %s diff --git a/llvm/lib/Support/RISCVISAInfo.cpp b/llvm/lib/Support/RISCVISAInfo.cpp index a02c9842e85839a..a3045657e63b724 100644 --- a/llvm/lib/Support/RISCVISAInfo.cpp +++ b/llvm/lib/Support/RISCVISAInfo.cpp @@ -116,12 +116,12 @@ static const RISCVSupportedExtension SupportedExtensions[] = { {"zicbom", RISCVExtensionVersion{1, 0}}, {"zicbop", RISCVExtensionVersion{1, 0}}, {"zicboz", RISCVExtensionVersion{1, 0}}, - {"zicntr", RISCVExtensionVersion{1, 0}}, + {"zicntr", RISCVExtensionVersion{2, 0}}, {"zicsr", RISCVExtensionVersion{2, 0}}, {"zifencei", RISCVExtensionVersion{2, 0}}, {"zihintntl", RISCVExtensionVersion{1, 0}}, {"zihintpause", RISCVExtensionVersion{2, 0}}, - {"zihpm", RISCVExtensionVersion{1, 0}}, + {"zihpm", RISCVExtensionVersion{2, 0}}, {"zk", RISCVExtensionVersion{1, 0}}, {"zkn", RISCVExtensionVersion{1, 0}}, diff --git a/llvm/test/CodeGen/RISCV/attributes.ll b/llvm/test/CodeGen/RISCV/attributes.ll index 34209a2018e5070..29eaaee57868a83 100644 --- a/llvm/test/CodeGen/RISCV/attributes.ll +++ b/llvm/test/CodeGen/RISCV/attributes.ll @@ -241,8 +241,8 @@ ; RV32ZCMT: .attribute 5, "rv32i2p1_zicsr2p0_zca1p0_zcmt1p0" ; RV32ZICSR: .attribute 5, "rv32i2p1_zicsr2p0" ; RV32ZIFENCEI: .attribute 5, "rv32i2p1_zifencei2p0" -; RV32ZICNTR: .attribute 5, "rv32i2p1_zicntr1p0_zicsr2p0" -; RV32ZIHPM: .attribute 5, "rv32i2p1_zicsr2p0_zihpm1p0" +; RV32ZICNTR: .attribute 5, "rv32i2p1_zicntr2p0_zicsr2p0" +; RV32ZIHPM: .attribute 5, "rv32i2p1_zicsr2p0_zihpm2p0" ; RV32ZFA: .attribute 5, "rv32i2p1_f2p2_zicsr2p0_zfa0p2" ; RV32ZVBB: .attribute 5, "rv32i2p1_zicsr2p0_zvbb1p0_zve32x1p0_zvkb1p0_zvl32b1p0" ; RV32ZVBC: .attribute 5, "rv32i2p1_zicsr2p0_zvbc1p0_zve32x1p0_zve64x1p0_zvl32b1p0_zvl64b1p0" @@ -330,8 +330,8 @@ ; RV64ZCMT: .attribute 5, "rv64i2p1_zicsr2p0_zca1p0_zcmt1p0" ; RV64ZICSR: .attribute 5, "rv64i2p1_zicsr2p0" ; RV64ZIFENCEI: .attribute 5, "rv64i2p1_zifencei2p0" -; RV64ZICNTR: .attribute 5, "rv64i2p1_zicntr1p0_zicsr2p0" -; RV64ZIHPM: .attribute 5, "rv64i2p1_zicsr2p0_zihpm1p0" +; RV64ZICNTR: .attribute 5, "rv64i2p1_zicntr2p0_zicsr2p0" +; RV64ZIHPM: .attribute 5, "rv64i2p1_zicsr2p0_zihpm2p0" ; RV64ZFA: .attribute 5, "rv64i2p1_f2p2_zicsr2p0_zfa0p2" ; RV64ZVBB: .attribute 5, "rv64i2p1_zicsr2p0_zvbb1p0_zve32x1p0_zvkb1p0_zvl32b1p0" ; RV64ZVBC: .attribute 5, "rv64i2p1_zicsr2p0_zvbc1p0_zve32x1p0_zve64x1p0_zvl32b1p0_zvl64b1p0" diff --git a/llvm/unittests/Support/RISCVISAInfoTest.cpp b/llvm/unittests/Support/RISCVISAInfoTest.cpp index f27557e41f973e2..1f7cc5ef1942a72 100644 --- a/llvm/unittests/Support/RISCVISAInfoTest.cpp +++ b/llvm/unittests/Support/RISCVISAInfoTest.cpp @@ -629,7 +629,7 @@ TEST(getTargetFeatureForExtension, RetrieveTargetFeatureFromOneExt) { TEST(RiscvExtensionsHelp, CheckExtensions) { std::string ExpectedOutput = -R"(All available -march extensions for RISC-V + R"(All available -march extensions for RISC-V Name Version i 2.1 @@ -644,12 +644,12 @@ R"(All available -march extensions for RISC-V zicbom 1.0 zicbop 1.0 zicboz 1.0 - zicntr 1.0 + zicntr 2.0 zicsr 2.0 zifencei 2.0 zihintntl 1.0 zihintpause 2.0 - zihpm 1.0 + zihpm 2.0 zmmul 1.0 zawrs 1.0 zfh 1.0 |
Your commit bumps both the counter and timer extension, which makes your commit message inaccurate. |
I think Counters in RISCV ISA include both "Zicntr" and "Zihpm", https://github.com/riscv/riscv-isa-manual/blob/main/src/counters.adoc. |
Sorry, that was a mis-statement. There are two counter extensions you are bumping. Anyway, rewording the commit message is a nit from me. |
6bffbf1
to
3925b94
Compare
OK, I retitle the commit. |
3925b94
to
569ce2e
Compare
No description provided.