[SPIRV] Add support for SPV_KHR_bit_instructions #66215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft version of patch to add support for SPV_KHR_bit_instructions. Created revision so we can discuss how to proceed here. SPV_KHR_bit_instructions (http://htmlpreview.github.io/?https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_bit_instructions.html), adds support for instructions that we already support through the Shader capability but without requiring the shader cap. However we currently have no way to disable the shader cap afaiu. On the other hand, SPV_KHR_bit_instructions was one of the extensions @mpaszkowski listed that we need to implement. So what does it mean at the moment the need to implement this? Is it just the ability to issue the extension and capabilities instructions without issuing the Shader capability? If so, then I will need to add here a way to disable the Shader capability. What do you think? Differential Revision: https://reviews.llvm.org/D156661
pmatos
force-pushed
the
SPV_KHR_bit_instructions
branch
from
48fa660 to
7cfad02
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
iliya-diyachkov
approved these changes
Sep 22, 2023
|
@iliya-diyachkov thanks for the time to review this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft version of patch to add support for SPV_KHR_bit_instructions.
Created revision so we can discuss how to proceed here.
SPV_KHR_bit_instructions (http://htmlpreview.github.io/?https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_bit_instructions.html),
adds support for instructions that we already support through
the Shader capability but without requiring the shader cap.
However we currently have no way to disable the shader cap afaiu.
On the other hand, SPV_KHR_bit_instructions was one of the
extensions @mpaszkowski listed that we need to implement.
So what does it mean at the moment the need to implement this?
Is it just the ability to issue the extension and capabilities
instructions without issuing the Shader capability? If so,
then I will need to add here a way to disable the Shader
capability. What do you think?
Previously https://reviews.llvm.org/D156661