[mlir][bufferization] Empty tensor elimination based on SubsetOpInterface #65766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
mlir:core
maerhart
approved these changes
Sep 12, 2023
mlir/include/mlir/Dialect/Bufferization/IR/SubsetOpInterface.td
Outdated
Show resolved
Hide resolved
Comment on lines
+114
to
+116
| "tensor.empty" ops cannot be bufferized. They can either be converted to | ||
| "bufferization.alloc_tensor" or replaced with another tensor (via this | ||
| transform). "tensor.empty" does not specify the contents of the returned |
There was a problem hiding this comment.
Just wondering why you are replacing back ticks with "?
There was a problem hiding this comment.
I think backticks are used when referring to function/variable names only.
There was a problem hiding this comment.
Interesting, I often do the exact opposite. Is there a written guideline somewhere?
…face This commit generalizes empty tensor elimination to operate on subset ops. No new test cases are added because all current subset ops were already supported by previously. From this perspective, this change is NFC. A new interface method (and a helper method) are added to `SubsetOpInterface` to build the subset of the destination tensor.
matthias-springer
force-pushed
the
subset_op_empty_tensor_elim
branch
from
97c2c4c to
f40a969
Compare
kstoimenov
pushed a commit
to kstoimenov/llvm-project
that referenced
this pull request
Sep 14, 2023
…face (llvm#65766) This commit generalizes empty tensor elimination to operate on subset ops. No new test cases are added because all current subset ops were already supported previously. From this perspective, this change is NFC. A new interface method (and a helper method) are added to `SubsetInsertionOpInterface` to build the subset of the destination tensor.
This was referenced Sep 14, 2023
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…face (llvm#65766) This commit generalizes empty tensor elimination to operate on subset ops. No new test cases are added because all current subset ops were already supported previously. From this perspective, this change is NFC. A new interface method (and a helper method) are added to `SubsetInsertionOpInterface` to build the subset of the destination tensor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit generalizes empty tensor elimination to operate on subset ops. No new test cases are added because all current subset ops were already supported previously. From this perspective, this change is NFC.
A new interface method (and a helper method) are added to
SubsetInsertionOpInterfaceto build the subset of the destination tensor.