[clang][bpf] Fix invalid RUN lines in stack protector warning test #65251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 of them were missing the ":" on the end. Adding them broke the test so I had to add a new prefix just for the warning runs only. I manually checked the first RUNs and there is no warning emitted, as expected.
|
@eddyz87 ping! |
|
I'm going to assume this is fine given that the test passes. We can always revert it if that is not the case. |
kstoimenov
pushed a commit
to kstoimenov/llvm-project
that referenced
this pull request
Sep 14, 2023
…lvm#65251) 2 of them were missing the ":" on the end. Adding them broke the test so I had to add a new prefix just for the warning runs only. I manually checked the first RUNs and there is no warning emitted, as expected.
This was referenced Sep 14, 2023
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…lvm#65251) 2 of them were missing the ":" on the end. Adding them broke the test so I had to add a new prefix just for the warning runs only. I manually checked the first RUNs and there is no warning emitted, as expected.
@DavidSpickett, my apologies, I messed up my notification settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 of them were missing the ":" on the end.
Adding them broke the test so I had to add a new prefix just for the warning runs only.
I manually checked the first RUNs and there is no warning emitted, as expected.