Add no-rosegment by default for API 29 and earlier.

[hiraditya]

Patch copied from android/ndk#1294 (comment)

Details in: android/ndk#1196
Fixes: android/ndk#1294

[llvmbot]

@llvm/pr-subscribers-clang

@llvm/pr-subscribers-clang-driver

Author: AdityaK (hiraditya)

Changes

Details in: android/ndk#1196
Fixes: android/ndk#1294

---

Full diff: https://github.com/llvm/llvm-project/pull/117611.diff

1 Files Affected:

• (modified) clang/lib/Driver/ToolChains/Linux.cpp (+8)

diff --git a/clang/lib/Driver/ToolChains/Linux.cpp b/clang/lib/Driver/ToolChains/Linux.cpp
index d1cb625613415b..5cc3d6feaa434f 100644
--- a/clang/lib/Driver/ToolChains/Linux.cpp
+++ b/clang/lib/Driver/ToolChains/Linux.cpp
@@ -256,6 +256,14 @@ Linux::Linux(const Driver &D, const llvm::Triple &Triple, const ArgList &Args)
       ExtraOpts.push_back("-z");
       ExtraOpts.push_back("max-page-size=16384");
     }
+    if (Triple.isAndroidVersionLT(29)) {
+      // https://github.com/android/ndk/issues/1196
+      // The unwinder used by the crash handler on versions of Android prior to
+      // API 29 did not correctly handle binaries built with rosegment, which is
+      // enabled by default for LLD. Android only supports LLD, so it's not an
+      // issue that this flag is not accepted by other linkers.
+      ExtraOpts.push_back("--no-rosegment");
+    }
   }
 
   if (GCCInstallation.getParentLibPath().contains("opt/rh/"))

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.