-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MLIR] Fix a stack-use-after-scope error in OpFormatGen.cpp #114789
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@llvm/pr-subscribers-mlir-core Author: Haojian Wu (hokein) ChangesFull diff: https://github.com/llvm/llvm-project/pull/114789.diff 1 Files Affected:
diff --git a/mlir/tools/mlir-tblgen/OpFormatGen.cpp b/mlir/tools/mlir-tblgen/OpFormatGen.cpp
index 3bf6f2f6d38176..7e2b0694a860a3 100644
--- a/mlir/tools/mlir-tblgen/OpFormatGen.cpp
+++ b/mlir/tools/mlir-tblgen/OpFormatGen.cpp
@@ -229,10 +229,9 @@ class OIListElement : public DirectiveElementBase<DirectiveElement::OIList> {
/// Returns a range to iterate over the LiteralElements.
auto getLiteralElements() const {
- function_ref<LiteralElement *(FormatElement * el)>
- literalElementCastConverter =
- [](FormatElement *el) { return cast<LiteralElement>(el); };
- return llvm::map_range(literalElements, literalElementCastConverter);
+ return llvm::map_range(literalElements, [](FormatElement *el) {
+ return cast<LiteralElement>(el);
+ });
}
/// Returns a range to iterate over the parsing elements corresponding to the
|
@llvm/pr-subscribers-mlir Author: Haojian Wu (hokein) ChangesFull diff: https://github.com/llvm/llvm-project/pull/114789.diff 1 Files Affected:
diff --git a/mlir/tools/mlir-tblgen/OpFormatGen.cpp b/mlir/tools/mlir-tblgen/OpFormatGen.cpp
index 3bf6f2f6d38176..7e2b0694a860a3 100644
--- a/mlir/tools/mlir-tblgen/OpFormatGen.cpp
+++ b/mlir/tools/mlir-tblgen/OpFormatGen.cpp
@@ -229,10 +229,9 @@ class OIListElement : public DirectiveElementBase<DirectiveElement::OIList> {
/// Returns a range to iterate over the LiteralElements.
auto getLiteralElements() const {
- function_ref<LiteralElement *(FormatElement * el)>
- literalElementCastConverter =
- [](FormatElement *el) { return cast<LiteralElement>(el); };
- return llvm::map_range(literalElements, literalElementCastConverter);
+ return llvm::map_range(literalElements, [](FormatElement *el) {
+ return cast<LiteralElement>(el);
+ });
}
/// Returns a range to iterate over the parsing elements corresponding to the
|
joker-eph
approved these changes
Nov 4, 2024
joker-eph
changed the title
[MLIR] Fix a use-after-free in OpFormatGen.cpp
[MLIR] Fix a stack-use-after-scope error in OpFormatGen.cpp
Nov 4, 2024
I just tweaked the title, hopefully it makes sense. Thanks for the fix! |
Make senses, thanks for the prompt review. |
usx95
approved these changes
Nov 4, 2024
PhilippRados
pushed a commit
to PhilippRados/llvm-project
that referenced
this pull request
Nov 6, 2024
hokein
added a commit
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.