[JITLink] fix i686 R_386_32 relocation value #111091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
changed the title
|
Thanks very much at @vtjnash! Do you think you could add a test with a non-zero addend in |
vtjnash
force-pushed
the
jn/JITLink-R_386_32
branch
from
202a0a1 to
4731ac2
Compare
|
Yes, thanks for pointing out where the tests are. I fixed all of the other relocations too, since most of them were similarly wrong. |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
vtjnash
force-pushed
the
jn/JITLink-R_386_32
branch
from
4731ac2 to
0abd57d
Compare
Most relocations involve adding the value at the location with a value taken from elsewhere. Most of them were hard coded instead. Assume signed, since the math is the same either way after truncation, but this seems more likely to give reasonable looking intermediate results.
vtjnash
force-pushed
the
jn/JITLink-R_386_32
branch
from
0abd57d to
0d56a9f
Compare
|
bump |
|
I don't actually have merge rights anymore, so you will need to land it for me |
|
@vtjnash Thanks for the heads up. Merged. :) |
bricknerb
pushed a commit
to bricknerb/llvm-project
that referenced
this pull request
Oct 16, 2024
Fix R_386_32 and other relocations by correcting Addend computations.
bricknerb
pushed a commit
to bricknerb/llvm-project
that referenced
this pull request
Oct 17, 2024
Fix R_386_32 and other relocations by correcting Addend computations.
EricWF
pushed a commit
to efcs/llvm-project
that referenced
this pull request
Oct 22, 2024
Fix R_386_32 and other relocations by correcting Addend computations.
giordano
pushed a commit
to JuliaLang/llvm-project
that referenced
this pull request
Nov 3, 2024
Fix R_386_32 and other relocations by correcting Addend computations. (cherry picked from commit 5716f83)
giordano
pushed a commit
to JuliaLang/llvm-project
that referenced
this pull request
Nov 21, 2024
Fix R_386_32 and other relocations by correcting Addend computations. (cherry picked from commit 5716f83)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My i686 builds were segfaulting when trying to enable JITLink, and I traced it back to an incorrect Addend computation here. Most relocations involve adding the value at the location with a value taken from elsewhere. This one was missing the addend taken from the location, but other relocations may be missing this too?
@lhames @llvm/issue-subscribers-julialang