Add symbol visibility macros to abi-breaking.h.cmake #110898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annotating these symbols will fix missing symbols errors for Bugpoint when when the default symbol visibility is set to hidden for LLVM. This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and plugins on window.
Open
40 tasks
compnerd
approved these changes
Oct 6, 2024
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/5136 Here is the relevant piece of the build log for the reference |
|
I guess we will need an lldb expert to decipher that test. @shafik, do you have a clue what might be going wrong here? |
|
Looks like this was temporary instability. The next build was successful: https://lab.llvm.org/buildbot/#/builders/18/builds/5137 |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/1345 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/1186 Here is the relevant piece of the build log for the reference |
|
I just found this actually introduce a cyclic module dependency: abi-breaking.h -> Compiler.h -> lllvm-config.h abi-breaking and llvm-config belong to the same module. |
|
I wonder how best to fix it, would excluding Compiler.h from the LLVM_Utils module work? |
|
Maybe we need to break apart LLVM_Config. I don't have other better idea. |
|
We should probably make Compiler.h textual. |
|
Any chance for a fix for this? The cyclic dependency is unfortunately breaking our build bots. |
|
I don't mind if you revert it for now until we get the right fix for it. |
Was that tried, @juliannagele? |
juliannagele
added a commit
that referenced
this pull request
Dec 3, 2024
This reverts commit 3be6916.
juliannagele
added a commit
that referenced
this pull request
Dec 3, 2024
Reverts #110898 This change has caused a cyclic module dependency `fatal error: cyclic dependency in module 'LLVM_Utils': LLVM_Utils -> LLVM_Config_ABI_Breaking -> LLVM_Utils`. Reverting for now until we the right fix.
👍 reverted for now |
I wouldn't know I'm afraid, happy to give it a try if you have a patch. |
diff --git a/llvm/include/module.modulemap b/llvm/include/module.modulemap
index b00da6d7cd28..0c05e4cf674d 100644
--- a/llvm/include/module.modulemap
+++ b/llvm/include/module.modulemap
@@ -389,7 +389,7 @@ module LLVM_Utils {
exclude header "llvm/Support/PluginLoader.h"
exclude header "llvm/Support/Solaris/sys/regset.h"
textual header "llvm/Support/TargetOpcodes.def"
-
+ textual header "llvm/Support/Compiler.h"
}
module TargetParser { |
Thanks, afaict that would fix the cyclic dependency (then exposing another issue that looks unrelated). |
|
That's great! Can you revert the revert and insert that fix instead? |
TIFitis
pushed a commit
to TIFitis/llvm-project
that referenced
this pull request
Dec 18, 2024
…18464) Reverts llvm#110898 This change has caused a cyclic module dependency `fatal error: cyclic dependency in module 'LLVM_Utils': LLVM_Utils -> LLVM_Config_ABI_Breaking -> LLVM_Utils`. Reverting for now until we the right fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotating these symbols will fix missing symbols errors for Bugpoint when when the default symbol visibility is set to hidden for LLVM.
This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and plugins on window.