[msan] Add more NEON VST tests #100189
Merged
[msan] Add more NEON VST tests #100189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes additional test cases that are currently unsupported by
MSan: VST_{2,3,4} with floating-point parameters, and VST1x_{2,3,4}.
vitalybuka
approved these changes
Jul 23, 2024
thurstond
added a commit
to thurstond/llvm-project
that referenced
this pull request
Jul 23, 2024
thurstond
added a commit
that referenced
this pull request
Jul 23, 2024
thurstond
added a commit
to thurstond/llvm-project
that referenced
this pull request
Jul 24, 2024
…meters
Cloning the vst_ functions to apply them to the shadows did not work if the arguments were floating-point, since the shadows are integers. This patch changes MSan to create an intrinsic of the correct integer types.
Additionally, this patch adds support for vst1x_{2,3,4}; these can be handled similarly to vst_{2,3,4}, since in all cases we are cloning/adapting
the corresponding function.
This also updates and enables the test introduced in llvm#100189
thurstond
added a commit
to thurstond/llvm-project
that referenced
this pull request
Jul 25, 2024
…meters
Cloning the vst_ functions to apply them to the shadows did not work if the arguments were floating-point, since the shadows are integers. This patch changes MSan to create an intrinsic of the correct integer types.
Additionally, this patch adds support for vst1x_{2,3,4}; these can be handled similarly to vst_{2,3,4}, since in all cases we are cloning/adapting the corresponding function.
This also updates and enables the test introduced in llvm#100189
thurstond
added a commit
to thurstond/llvm-project
that referenced
this pull request
Jul 25, 2024
…meters
Cloning the vst_ functions to apply them to the shadows did not work if the arguments were floating-point, since the shadows are integers. This patch changes MSan to create an intrinsic of the correct integer types.
Additionally, this patch adds support for vst1x_{2,3,4}; these can be handled similarly to vst_{2,3,4}, since in all cases we are cloning/adapting the corresponding function.
This also updates and enables the test introduced in llvm#100189
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary:
This includes additional test cases that are currently unsupported by
MSan: VST_{2,3,4} with floating-point parameters, and VST1x_{2,3,4}.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: https://phabricator.intern.facebook.com/D60251111
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
vitalybuka
pushed a commit
to thurstond/llvm-project
that referenced
this pull request
Jul 29, 2024
…meters
Cloning the vst_ functions to apply them to the shadows did not work if the arguments were floating-point, since the shadows are integers. This patch changes MSan to create an intrinsic of the correct integer types.
Additionally, this patch adds support for vst1x_{2,3,4}; these can be handled similarly to vst_{2,3,4}, since in all cases we are cloning/adapting the corresponding function.
This also updates and enables the test introduced in llvm#100189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes additional test cases that are currently unsupported by MSan: VST_{2,3,4} with floating-point parameters, and VST1x_{2,3,4}.