Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for https://github.com/llvm/llvm-project/pull/89884 #100061

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Fix tests for https://github.com/llvm/llvm-project/pull/89884 #100061

merged 1 commit into from
Jul 23, 2024

Conversation

kyulee-com
Copy link
Contributor

No description provided.

@kyulee-com kyulee-com requested review from dyung, alx32 and ellishg July 23, 2024 04:13
@kyulee-com kyulee-com mentioned this pull request Jul 23, 2024
Merged
@kyulee-com kyulee-com requested a review from vvereschaka July 23, 2024 04:17
@alx32
Copy link
Contributor

alx32 commented Jul 23, 2024

LGTM. Nit: current pattern is to not have space in REQUIRES: ... list , only ','

@kyulee-com
Copy link
Contributor Author

LGTM. Nit: current pattern is to not have space in REQUIRES: ... list , only ','

Looking at other tests, they also seem have space -- https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/llvm-exegesis/X86/latency/loop-register.s#L1

@kyulee-com kyulee-com merged commit 67937a3 into llvm:main Jul 23, 2024
5 of 8 checks passed
@alx32
Copy link
Contributor

alx32 commented Jul 23, 2024

Looking at other tests, they also seem have space -- https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/llvm-exegesis/X86/latency/loop-register.s#L1

Indeed, now I see it varies depending on tests - so either is fine.

https://github.com/llvm/llvm-project/blob/main/clang/test/CodeGen/swift-async-extended-fp.c#L19

@vvereschaka
Copy link
Contributor

Thank you @kyulee-com
the tests on the nvptx builders have been fixed.

gulfemsavrun added a commit that referenced this pull request Jul 23, 2024
@gulfemsavrun
Revert "[CGData] llvm-cgdata (#89884)"
73d7897 
This reverts commit d3fb41d
and forward fix patches because of the issue explained in:
#89884 (comment).

Revert "Fix tests for #89884
(#100061)"

This reverts commit 67937a3.

Revert "Fix build break for #89884 (#100050)"

This reverts commit c33878c.

Revert "[CGData] Fix -Wpessimizing-move in CodeGenDataReader.cpp (NFC)"

This reverts commit 1f8b2b1.
sgundapa pushed a commit to sgundapa/upstream_effort that referenced this pull request Jul 23, 2024
@kyulee-com @sgundapa
Fix tests for llvm#89884 (llvm#100061)
e808b1f
sgundapa pushed a commit to sgundapa/upstream_effort that referenced this pull request Jul 23, 2024
@gulfemsavrun @sgundapa
Revert "[CGData] llvm-cgdata (llvm#89884)"
1f63257 
This reverts commit d3fb41d
and forward fix patches because of the issue explained in:
llvm#89884 (comment).

Revert "Fix tests for llvm#89884
(llvm#100061)"

This reverts commit 67937a3.

Revert "Fix build break for llvm#89884 (llvm#100050)"

This reverts commit c33878c.

Revert "[CGData] Fix -Wpessimizing-move in CodeGenDataReader.cpp (NFC)"

This reverts commit 1f8b2b1.
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
@kyulee-com @yuxuanchen1997
Fix tests for #89884 (#100061)
9e0ed0d 
Summary: 

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251302
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
@gulfemsavrun @yuxuanchen1997
Revert "[CGData] llvm-cgdata (#89884)"
94a8a19 
This reverts commit d3fb41d
and forward fix patches because of the issue explained in:
#89884 (comment).

Revert "Fix tests for #89884
(#100061)"

This reverts commit 67937a3.

Revert "Fix build break for #89884 (#100050)"

This reverts commit c33878c.

Revert "[CGData] Fix -Wpessimizing-move in CodeGenDataReader.cpp (NFC)"

This reverts commit 1f8b2b1.
llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Aug 14, 2024
@gulfemsavrun @llvmbot
Revert "[CGData] llvm-cgdata (llvm#89884)"
40f2a4c 
This reverts commit d3fb41d
and forward fix patches because of the issue explained in:
llvm#89884 (comment).

Revert "Fix tests for llvm#89884
(llvm#100061)"

This reverts commit 67937a3.

Revert "Fix build break for llvm#89884 (llvm#100050)"

This reverts commit c33878c.

Revert "[CGData] Fix -Wpessimizing-move in CodeGenDataReader.cpp (NFC)"

This reverts commit 1f8b2b1.

(cherry picked from commit 73d7897)
tru pushed a commit to llvmbot/llvm-project that referenced this pull request Aug 19, 2024
@gulfemsavrun @tru
Revert "[CGData] llvm-cgdata (llvm#89884)"
9e90c40 
This reverts commit d3fb41d
and forward fix patches because of the issue explained in:
llvm#89884 (comment).

Revert "Fix tests for llvm#89884
(llvm#100061)"

This reverts commit 67937a3.

Revert "Fix build break for llvm#89884 (llvm#100050)"

This reverts commit c33878c.

Revert "[CGData] Fix -Wpessimizing-move in CodeGenDataReader.cpp (NFC)"

This reverts commit 1f8b2b1.

(cherry picked from commit 73d7897)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alx32 alx32 alx32 approved these changes

@dyung dyung Awaiting requested review from dyung

@ellishg ellishg Awaiting requested review from ellishg

@vvereschaka vvereschaka Awaiting requested review from vvereschaka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyulee-com @alx32 @vvereschaka