Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[X86] GlobalIsel removed type info when legalizing ICMP, causing out of bound access on debug build #86203

Closed
DataCorrupted opened this issue Mar 21, 2024 · 2 comments · Fixed by #86221
Closed

[X86] GlobalIsel removed type info when legalizing ICMP, causing out of bound access on debug build #86203

DataCorrupted opened this issue Mar 21, 2024 · 2 comments · Fixed by #86221
Assignees
@e-kud
Labels
backend:X86 crash-on-valid llvm:globalisel

Comments

@DataCorrupted
Copy link
Member

DataCorrupted commented Mar 21, 2024 •
edited
Loading

Reproduction

Out of bound on debug build
Unable to legalize on release build

The bug can be reproduced on LLVM 16, 17, and upstream.

@phoebewang Any hints on how should we fix this?
@llvmbot
Copy link
Member

llvmbot commented Mar 21, 2024

@llvm/issue-subscribers-backend-x86

Author: Peter Rong (DataCorrupted)

## Reproduction

Out of bound on debug build
Unable to legalize on release build

The bug can be reproduced on LLVM 16, 17, and upstream.

@phoebewang Any hints on how should we fix this?

@e-kud
Copy link
Contributor

e-kud commented Mar 21, 2024 •
edited
Loading

The bug was introduced by me. Preparing a fix.

@e-kud e-kud self-assigned this Mar 21, 2024
@e-kud e-kud mentioned this issue Mar 22, 2024
Merged
e-kud added a commit that referenced this issue Mar 25, 2024
@e-kud
[X86][GlobalISel] Fix referencing nonexistent operand in G_ICMP (#86221)
fb39456 
Fixes #86203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e-kud e-kud

Labels
backend:X86 crash-on-valid llvm:globalisel
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[X86][GlobalISel] Fix referencing nonexistent operand in G_ICMP e-kud/llvm-project
3 participants
@e-kud @DataCorrupted @llvmbot