Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tidy-diff.py should exit with a failure code when there are errors #65000

Closed
FlashSheridan opened this issue Aug 26, 2023 · 2 comments
Closed

clang-tidy-diff.py should exit with a failure code when there are errors #65000

FlashSheridan opened this issue Aug 26, 2023 · 2 comments
Assignees
@PiotrZSL
Labels
clang-tidy

Comments

@FlashSheridan
Copy link
Contributor

Similarly to #28002 for clang-tidy, clang-tidy-diff.py should have an option to exit with a failure code when there are errors; this would make our GitHub Action much simpler. Even with WarningsAsErrors set, I get “1 warning treated as error” but a 0 return code; even in quiet mode there some output even if there are no warnings, which would complicate the workaround I was contemplating.
@llvmbot
Copy link
Member

llvmbot commented Aug 26, 2023

@llvm/issue-subscribers-clang-tidy

@FlashSheridan FlashSheridan mentioned this issue Aug 26, 2023
Closed
@PiotrZSL
Copy link
Member

https://reviews.llvm.org/D158929
If someone could test it, it would be nice.

@PiotrZSL PiotrZSL self-assigned this Aug 26, 2023
@PiotrZSL PiotrZSL added the awaiting-review Has pending Phabricator review label Aug 26, 2023
FlashSheridan added a commit to matter-labs/era-compiler-llvm that referenced this issue Aug 29, 2023
@FlashSheridan
Adding a proposed revision of clang-tidy-diff.py by Piotr Zegar, incl…
0dfa3d1 
…uding the text below,

in accordance with the following part of https://llvm.org/LICENSE.txt:

      (b) You must cause any modified files to carry prominent notices
          stating that You changed the files; and

 This is a proposed revision of clang-tidy-diff.py by Piotr Zegar: https://reviews.llvm.org/D158929
for llvm/llvm-project#65000, eventually to be committed upstream.
It is being committed to the Matter Labs fork of  LLVM, and might be further modified
by its employees.
@PiotrZSL PiotrZSL removed the awaiting-review Has pending Phabricator review label Aug 31, 2023
@smeenai smeenai mentioned this issue Sep 1, 2023
Closed
smeenai pushed a commit to smeenai/llvm-project that referenced this issue Sep 1, 2023
@PiotrZSL @smeenai
[clang-tidy] Add exit code support to clang-tidy-diff.py
d1d1f21 
Modify script to fail when some run clang-tidy
command fails. Based on run_clang-tidy.

Fixes: llvm#65000

Reviewed By: carlosgalvezp

Differential Revision: https://reviews.llvm.org/D158929

commit-id:f05b3f73
@FlashSheridan FlashSheridan mentioned this issue Sep 14, 2023
Merged
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 22, 2024
@Lai-YT
Run clang tidy on diff with CI
3461ca4 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff.py` supports exit with a failure code when there are
   errors from version 17 onward. (The exact version is uncertain. For
   more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not work if any of these issues occur.
In the CI environment, we ensure that the versions of these dependencies
are new enough.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 22, 2024
@Lai-YT
Run clang tidy on diff with CI
bf8ca05 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff.py` supports exit with a failure code when there are
   errors from version 17 onward. (The exact version is uncertain. For
   more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not work if any of these issues occur.
In the CI environment, we ensure that the versions of these dependencies
are new enough.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 22, 2024
@Lai-YT
Run clang tidy on diff with CI
11d5d42 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff.py` supports exit with a failure code when there are
   errors from version 17 onward. (The exact version is uncertain. For
   more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `17`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 22, 2024
@Lai-YT
Run clang tidy on diff with CI
7efcb09 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 onward. (The exact version is uncertain. For
   more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `17`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
@Lai-YT Lai-YT mentioned this issue Feb 22, 2024
Merged
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 22, 2024
@Lai-YT
Run clang tidy on diff with CI
72147a7 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 onward. (The exact version is uncertain. For
   more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `17`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 22, 2024
@Lai-YT
Run clang tidy on diff with CI
f687292 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 22, 2024
@Lai-YT
Run clang tidy on diff with CI
52c1c69 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 22, 2024
@Lai-YT
Run clang tidy on diff with CI
8540426 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 22, 2024
@Lai-YT
Run clang tidy on diff with CI
a89063d 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 22, 2024
@Lai-YT
Run clang tidy on diff with CI
3a25b3a 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 22, 2024
@Lai-YT
Run clang tidy on diff with CI
33fdbd3 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
b6a242e 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
85a144e 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
b8f5554 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
b3cdc90 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
ce61ca3 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
339a72b 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
ebe74a0 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
7cd191a 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
3e545cb 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
711724d 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
d298ef0 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
aa47644 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
63fafa0 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
19fa344 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
64310e5 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
6dc49a3 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
31e4cd2 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
b4c64c2 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
f5ef9dc 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Lai-YT added a commit to Lai-YT/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT
Run clang tidy on diff with CI
2d88d68 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
leewei05 pushed a commit to fruits-lab/vitaminc that referenced this issue Feb 23, 2024
@Lai-YT @leewei05
Run clang tidy on diff with CI
7367699 
Added a script for CI execution. This script is not intended for local
user execution due to the following reasons:

1. `clang-tidy-diff` supports exit with a failure code when there are
   errors from version 17 or 18 onward. (The exact version is uncertain.
   For more details, please refer to
   llvm/llvm-project#65000.)
2. `bear` has different command line interfaces between version <= 2.4.x
    and onward. (For more details, please refer to
    https://github.com/rizsotto/Bear?tab=readme-ov-file#how-to-use.)

The script may not function properly if any of these issues arise. In
the CI environment, we ensure that the versions of these dependencies
are up-to-date. Specifically, the version of `clang-tidy-diff` is
specified as `18`, and the version of `Bear` on Ubuntu 22.04 is 3.0.x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PiotrZSL PiotrZSL

Labels
clang-tidy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@FlashSheridan @PiotrZSL @EugeneZelenko @llvmbot