Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch for Phabricator is out-of-date #64470

Closed
yichi170 opened this issue Aug 6, 2023 · 4 comments
Closed

Patch for Phabricator is out-of-date #64470

yichi170 opened this issue Aug 6, 2023 · 4 comments
Labels
infrastructure Bugs about LLVM infrastructure

Comments

@yichi170
Copy link
Contributor

yichi170 commented Aug 6, 2023

As the title mentioned, the patch for Phabricator is out-of-date and cannot directly apply to the https://github.com/phacility/arcanist

The patch is here: https://github.com/llvm/llvm-project/blob/main/llvm/utils/phabricator/0001-Fix-PHP-8.1-incompatibility-with-arc-patch-D-12345.patch
@Endilll Endilll added infrastructure Bugs about LLVM infrastructure and removed new issue labels Aug 6, 2023
@llvmbot
Copy link
Member

llvmbot commented Aug 6, 2023

@llvm/issue-subscribers-infrastructure

@Endilll
Copy link
Contributor

Endilll commented Aug 6, 2023

CC @nickdesaulniers as author of aforementioned patch

@nickdesaulniers
Copy link
Member

out of date? Did arcanist come out of archival status?

Anyways, LLVM is moving to github for code reviews; I'm not going to maintain arcanist support.

@joker-eph
Copy link
Collaborator

The commits in arcanist are about php8 compatibility, so it is likely that the LLVM patch isn't needed anymore.

smeenai pushed a commit to smeenai/llvm-project that referenced this issue Sep 1, 2023
@nickdesaulniers @smeenai
Revert "[llvm][docs] commit phabricator patch"
033f2af 
This reverts commit ef4beb8.

It also removes the prior note about needing to patch ``arcanist``.

This is patch is no longer necessary:
1. arcanist came out of hibernation and updated to support PHP 8.1.
   https://github.com/phacility/arcanist/commits/master
2. llvm/llvm-project is moving to github pull requests starting Sept 1
   (tomorrow).
   https://discourse.llvm.org/t/pull-request-migration-schedule/71595

Fixes: llvm#64470

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D159291

commit-id:94c4d093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Bugs about LLVM infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nickdesaulniers @joker-eph @Endilll @yichi170 @llvmbot