Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readability-container-size-empty should handle std::string length() #37603

Closed
EugeneZelenko opened this issue Jul 20, 2018 · 4 comments
Closed

readability-container-size-empty should handle std::string length() #37603

EugeneZelenko opened this issue Jul 20, 2018 · 4 comments
Assignees
@PiotrZSL
Labels
bugzilla Issues migrated from bugzilla clang-tidy enhancement Improving things as opposed to bug fixing, e.g. new or missing feature

Comments

@EugeneZelenko
Copy link
Contributor

Bugzilla Link 38255
Version unspecified
OS All
CC @Xazax-hun

Extended Description

length() is synonym for size in std::string and should be handled in same way as size().
@llvmbot
Copy link
Member

llvmbot commented Jan 13, 2019

https://reviews.llvm.org/D56644

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
@EugeneZelenko EugeneZelenko added the enhancement Improving things as opposed to bug fixing, e.g. new or missing feature label Jan 21, 2022
@PiotrZSL PiotrZSL self-assigned this Aug 8, 2023
@PiotrZSL PiotrZSL added the awaiting-review Has pending Phabricator review label Aug 8, 2023
@Endilll Endilll added good first issue https://github.com/llvm/llvm-project/contribute and removed beginner labels Aug 15, 2023
@llvmbot
Copy link
Member

llvmbot commented Aug 15, 2023

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Assign the issue to you.
  2. Fix the issue locally.
  3. Run the test suite locally.
    3.1) Remember that the subdirectories under test/ create fine-grained testing targets, so you can
    e.g. use make check-clang-ast to only run Clang's AST tests.
  4. Create a git commit
  5. Run git clang-format HEAD~1 to format your changes.
  6. Submit the patch to Phabricator.
    6.1) Detailed instructions can be found here

For more instructions on how to submit a patch to LLVM, see our documentation.

If you have any further questions about this issue, don't hesitate to ask via a comment on this Github issue.

@llvm/issue-subscribers-good-first-issue

@PiotrZSL PiotrZSL removed the good first issue https://github.com/llvm/llvm-project/contribute label Aug 15, 2023
@PiotrZSL
Copy link
Member

Actually code is waiting for review.

@EugeneZelenko
Copy link
Contributor Author

This was done because of unification of labels (beginner -> good first issue).

@PiotrZSL PiotrZSL removed the awaiting-review Has pending Phabricator review label Aug 31, 2023
@smeenai smeenai mentioned this issue Sep 1, 2023
Closed
smeenai pushed a commit to smeenai/llvm-project that referenced this issue Sep 1, 2023
@PiotrZSL @smeenai
[clang-tidy] readability-container-size-empty handle std::string leng…
2383ed7 
…th()

Extends readability-container-size-empty to check std::string length() similar to size().

Fixes: llvm#37603

Co-authored-by: Dmitry Venikov <[email protected]>

Reviewed By: carlosgalvezp

Differential Revision: https://reviews.llvm.org/D56644

commit-id:56527293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PiotrZSL PiotrZSL

Labels
bugzilla Issues migrated from bugzilla clang-tidy enhancement Improving things as opposed to bug fixing, e.g. new or missing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@PiotrZSL @EugeneZelenko @Endilll @llvmbot