Skip to content

Commit

Permalink
[mlgo] Fix state-tracking-coro.ll test
Browse files Browse the repository at this point in the history
Post #68263, the inline advisor printer tries to print SCC Nodes' names,
but if we perform a full pipeline (like O1), there'll be some DCE-ing
happening and the Node pointers kept in the advisor for this (printing)
purpose are dangling. Using the more eager printer post each scc inline
pass is sufficient.
  • Loading branch information
mtrofin committed Oct 5, 2023
1 parent c6ed5a6 commit a4765c6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion llvm/test/Transforms/Inline/ML/state-tracking-coro.ll
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
; Based on llvm/test/Transforms/Coroutines/coro-split-02.ll
; Corosplit will keep f1 and add 3 more functions.
; RUN: opt -passes='default<O1>,print<inline-advisor>' -training-log=/dev/null \
; RUN: -S -enable-ml-inliner=development -keep-inline-advisor-for-printing < %s 2>&1 | FileCheck %s
; RUN: -S -enable-ml-inliner=development -enable-scc-inline-advisor-printing < %s 2>&1 | FileCheck %s
; REQUIRES: have_tflite
;
; CHECK: [MLInlineAdvisor] Nodes: 1 Edges: 0
; CHECK: [MLInlineAdvisor] Nodes: 4 Edges: 0

%"struct.std::coroutine_handle" = type { ptr }
Expand Down

0 comments on commit a4765c6

Please sign in to comment.