-
Notifications
You must be signed in to change notification settings - Fork 12.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[WebAssembly] Don't assume that zext/sext result is i32/i64 in fast i…
…sel (PR41841) Usually this will abort fast-isel at the instruction using the non-legal result, but if the only use is in a different basic block, we'll incorrectly assume that the zext/sext is to i32 (rather than i128 in this case). Differential Revision: https://reviews.llvm.org/D61823 llvm-svn: 360616
- Loading branch information
Showing
2 changed files
with
50 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
; RUN: llc < %s -O0 -wasm-disable-explicit-locals -wasm-keep-registers -asm-verbose=false | FileCheck %s | ||
|
||
target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128" | ||
target triple = "wasm32-unknown-unknown" | ||
|
||
declare void @foo(i128) | ||
|
||
; CHECK-LABEL: test_zext: | ||
; CHECK-NEXT: .functype test_zext (i32) -> (){{$}} | ||
; CHECK-NEXT: i64.extend_i32_u $[[TMP3:[0-9]+]]=, $0{{$}} | ||
; CHECK-NEXT: i64.const $[[TMP4:[0-9]+]]=, 1{{$}} | ||
; CHECK-NEXT: i64.and $[[TMP1:[0-9]+]]=, $[[TMP3]], $[[TMP4]]{{$}} | ||
; CHECK-NEXT: i64.const $[[TMP2:[0-9]+]]=, 0{{$}} | ||
; CHECK-NEXT: call foo, $[[TMP1]], $[[TMP2]]{{$}} | ||
; CHECK-NEXT: return{{$}} | ||
define void @test_zext(i1 %b) nounwind { | ||
%res = zext i1 %b to i128 | ||
br label %next | ||
|
||
next: ; preds = %start | ||
call void @foo(i128 %res) | ||
ret void | ||
} | ||
|
||
; CHECK-LABEL: test_sext: | ||
; CHECK-NEXT:.functype test_sext (i32) -> (){{$}} | ||
; CHECK-NEXT: i64.extend_i32_u $[[TMP3:[0-9]+]]=, $0{{$}} | ||
; CHECK-NEXT: i64.const $[[TMP4:[0-9]+]]=, 1{{$}} | ||
; CHECK-NEXT: i64.and $[[TMP5:[0-9]+]]=, $[[TMP3]], $[[TMP4]]{{$}} | ||
; CHECK-NEXT: i64.const $[[TMP6:[0-9]+]]=, 0{{$}} | ||
; CHECK-NEXT: i64.sub $[[TMP1:[0-9]+]]=, $[[TMP6]], $[[TMP5]]{{$}} | ||
; CHECK-NEXT: local.copy $[[TMP2:[0-9]+]]=, $[[TMP1]]{{$}} | ||
; CHECK-NEXT: call foo, $[[TMP1]], $[[TMP2]]{{$}} | ||
; CHECK-NEXT: return{{$}} | ||
define void @test_sext(i1 %b) nounwind { | ||
%res = sext i1 %b to i128 | ||
br label %next | ||
|
||
next: ; preds = %start | ||
call void @foo(i128 %res) | ||
ret void | ||
} |