Address feedbacks from Alex

llvm · Jul 11, 2024 · 13afd88 · 13afd88
1 parent d7dc2a1
commit 13afd88
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/llvm/include/llvm/CodeGenData/CodeGenData.h b/llvm/include/llvm/CodeGenData/CodeGenData.h
@@ -81,7 +81,7 @@ class CGDataError : public ErrorInfo<CGDataError> {
   /// contain a single CGDataError.
   static std::pair<cgdata_error, std::string> take(Error E) {
     auto Err = cgdata_error::success;
-    std::string Msg = "";
+    std::string Msg;
     handleAllErrors(std::move(E), [&Err, &Msg](const CGDataError &IPE) {
       assert(Err == cgdata_error::success && "Multiple errors encountered");
       Err = IPE.get();

diff --git a/llvm/lib/CodeGenData/CodeGenDataReader.cpp b/llvm/lib/CodeGenData/CodeGenDataReader.cpp
@@ -121,7 +121,7 @@ CodeGenDataReader::create(std::unique_ptr<MemoryBuffer> Buffer) {
 
 bool IndexedCodeGenDataReader::hasFormat(const MemoryBuffer &DataBuffer) {
   using namespace support;
-  if (DataBuffer.getBufferSize() < 8)
+  if (DataBuffer.getBufferSize() < sizeof(IndexedCGData::Magic))
     return false;
 
   uint64_t Magic = endian::read<uint64_t, llvm::endianness::little, aligned>(