Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#9) Command line flags #22

Merged
merged 1 commit into from
Mar 2, 2019
Merged

(#9) Command line flags #22

merged 1 commit into from
Mar 2, 2019

Conversation

llorllale
Copy link
Owner

This PR is for #9:

  • Filters and repo path are specified via command
    line flags
  • Can also specify flags via '.gitlint' file in
    $PWD (command line flags take precedence).
    The format of this file is the same as command
    line flags, where each is on a separate line.
  • Left a puzzle to remove global variables later

* Filters and repo path are specified via command
  line flags
* Can also specify flags via '.gitlint' file in
  $PWD (command line flags take precedence).
  The format of this file is the same as command
  line flags, where each is on a separate line.
@codecov
Copy link

codecov bot commented Mar 2, 2019

Codecov Report

Merging #22 into master will increase coverage by 1.2%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #22     +/-   ##
========================================
+ Coverage      85%   86.2%   +1.2%     
========================================
  Files           4       4             
  Lines          80      87      +7     
========================================
+ Hits           68      75      +7     
  Misses          6       6             
  Partials        6       6
Impacted Files Coverage Δ
internal/issues/filters.go 86.2% <100%> (+4.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76bb489...e9c2b56. Read the comment docs.

@llorllale llorllale merged commit 4be918f into master Mar 2, 2019
@llorllale llorllale deleted the 9 branch March 2, 2019 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant