Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#16) Add commit filters #17

Merged
merged 1 commit into from
Feb 24, 2019
Merged

(#16) Add commit filters #17

merged 1 commit into from
Feb 24, 2019

Conversation

llorllale
Copy link
Owner

PR for #16

  • New filters package
  • New issues package
  • Left puzzle to fix the coverage check

@codecov
Copy link

codecov bot commented Feb 24, 2019

Codecov Report

Merging #17 into master will decrease coverage by 2.11%.
The diff coverage is 83.67%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #17      +/-   ##
=========================================
- Coverage   84.61%   82.5%   -2.12%     
=========================================
  Files           2       4       +2     
  Lines          52      80      +28     
=========================================
+ Hits           44      66      +22     
- Misses          4       8       +4     
- Partials        4       6       +2
Impacted Files Coverage Δ
internal/commits/commits.go 80.64% <66.66%> (-6.32%) ⬇️
internal/commits/filter/filter.go 81.81% <81.81%> (ø)
internal/commits/issues/issues.go 90.47% <90.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db191c3...eff1b8c. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 24, 2019

Codecov Report

Merging #17 into master will increase coverage by 0.38%.
The diff coverage is 87.75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17      +/-   ##
=======================================
+ Coverage   84.61%   85%   +0.38%     
=======================================
  Files           2     4       +2     
  Lines          52    80      +28     
=======================================
+ Hits           44    68      +24     
- Misses          4     6       +2     
- Partials        4     6       +2
Impacted Files Coverage Δ
internal/commits/commits.go 87.09% <100%> (+0.14%) ⬆️
internal/commits/filter/filter.go 81.81% <81.81%> (ø)
internal/commits/issues/issues.go 90.47% <90.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db191c3...eff1b8c. Read the comment docs.

@llorllale llorllale merged commit b52f151 into master Feb 24, 2019
@llorllale llorllale deleted the 16 branch February 24, 2019 15:19
@llorllale llorllale mentioned this pull request Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant