(#34) Remove issues.Filter() (#35)

README.md

@@ -18,12 +18,12 @@ $ ./gitlint --help
 usage: gitlint [<flags>]
 
 Flags:
-  --help                         Show context-sensitive help (also try --help-long and --help-man).
-  --subject-regex=SUBJECT-REGEX  Filters commit subjects based on a regular expression.
-  --subject-len=SUBJECT-LEN      Filters commit subjects based on length.
-  --body-regex=BODY-REGEX        Filters commit message bodies based on a regular expression.
-  --path="."                     Path to the git repo ("." by default).
-  --since="1970-01-01"           A date in "yyyy-MM-dd" format starting from which commits will be analyzed (default: "1970-01-01")
+  --help                    Show context-sensitive help (also try --help-long and --help-man).
+  --path="."                Path to the git repo (default: ".").
+  --subject-regex=".*"      Commit subject line must conform to this regular expression (default: ".*").
+  --subject-len=4294967295  Commit subject line cannot exceed this length (default: math.MaxUint32).
+  --body-regex=".*"         Commit message body must conform to this regular expression (default: ".*").
+  --since="1970-01-01"      A date in "yyyy-MM-dd" format starting from which commits will be analyzed (default: "1970-01-01")
 ```
 Additionally, it will look for configurations in a file `.gitlint` in the current directory if it exists. This file's format is just the same command line flags but each on a separate line. *Flags passed through the command line take precedence.*
 

cmd/go-gitlint/main.go

@@ -15,7 +15,9 @@
 package main
 
 import (
+	"math"
 	"os"
+	"strconv"
 
 	"github.com/llorllale/go-gitlint/internal/commits"
 	"github.com/llorllale/go-gitlint/internal/issues"
@@ -28,8 +30,11 @@ import (
 //  Figure out a way to remove these global variables. Whatever command line
 //  parser we choose should be able to auto-generate usage.
 var (
-	path  = kingpin.Flag("path", `Path to the git repo ("." by default).`).Default(".").String()                                                                       //nolint[gochecknoglobals]
-	since = kingpin.Flag("since", `A date in "yyyy-MM-dd" format starting from which commits will be analyzed (default: "1970-01-01")`).Default("1970-01-01").String() //nolint[gochecknoglobals]
+	path          = kingpin.Flag("path", `Path to the git repo (default: ".").`).Default(".").String()                                                                         //nolint[gochecknoglobals]
+	subjectRegex  = kingpin.Flag("subject-regex", `Commit subject line must conform to this regular expression (default: ".*").`).Default(".*").String()                       //nolint[gochecknoglobals]
+	subjectLength = kingpin.Flag("subject-len", "Commit subject line cannot exceed this length (default: math.MaxUint32).").Default(strconv.Itoa(math.MaxUint32)).Int()        //nolint[gochecknoglobals]
+	bodyRegex     = kingpin.Flag("body-regex", `Commit message body must conform to this regular expression (default: ".*").`).Default(".*").String()                          //nolint[gochecknoglobals]
+	since         = kingpin.Flag("since", `A date in "yyyy-MM-dd" format starting from which commits will be analyzed (default: "1970-01-01")`).Default("1970-01-01").String() //nolint[gochecknoglobals]
 )
 
 func main() {
@@ -39,7 +44,11 @@ func main() {
 			issues.Printed(
 				os.Stdout, "\n",
 				issues.Collected(
-					issues.Filters(),
+					[]issues.Filter{
+						issues.OfSubjectRegex(*subjectRegex),
+						issues.OfBodyRegex(*bodyRegex),
+						issues.OfSubjectLength(*subjectLength),
+					},
 					commits.Since(
 						*since,
 						commits.In(

internal/issues/filters.go

@@ -19,39 +19,13 @@ import (
 	"regexp"
 
 	"github.com/llorllale/go-gitlint/internal/commits"
-	kingpin "gopkg.in/alecthomas/kingpin.v2"
-)
-
-var (
-	subjectRegex  = kingpin.Flag("subject-regex", "Filters commit subjects based on a regular expression.").String()    //nolint[gochecknoglobals]
-	subjectLength = kingpin.Flag("subject-len", "Filters commit subjects based on length.").Int()                       //nolint[gochecknoglobals]
-	bodyRegex     = kingpin.Flag("body-regex", "Filters commit message bodies based on a regular expression.").String() //nolint[gochecknoglobals]
 )
 
 // Filter identifies an issue with a commit.
 // A filter returning a zero-valued Issue signals that it found no issue
 // with the commit.
 type Filter func(*commits.Commit) Issue
 
-// Filters returns all filters configured by the user.
-// @todo #31 Function issues.Filters() can be removed by providing
-//  default values for each filter that will effectively render them
-//  disabled. For example, OfSubjectRegex() can be effectively disabled
-//  by using ".*" as regex.
-func Filters() []Filter {
-	filters := make([]Filter, 0)
-	if subjectRegex != nil {
-		filters = append(filters, OfSubjectRegex(*subjectRegex))
-	}
-	if bodyRegex != nil {
-		filters = append(filters, OfBodyRegex(*bodyRegex))
-	}
-	if subjectLength != nil && *subjectLength > 0 {
-		filters = append(filters, OfSubjectLength(*subjectLength))
-	}
-	return filters
-}
-
 // OfSubjectRegex tests a commit's subject with the regex.
 func OfSubjectRegex(regex string) Filter {
 	return func(c *commits.Commit) Issue {

internal/issues/filters_test.go

@@ -21,16 +21,6 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-func TestFilters(t *testing.T) {
-	sr := "abc123"
-	br := "bodyRegex"
-	sl := 5
-	subjectRegex = &sr
-	bodyRegex = &br
-	subjectLength = &sl
-	assert.Len(t, Filters(), 3)
-}
-
 func TestOfSubjectRegexMatch(t *testing.T) {
 	assert.Zero(t,
 		OfSubjectRegex(`\(#\d+\) [\w ]{10,50}`)(