Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test & Solution for #33 #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Test & Solution for #33 #79

wants to merge 2 commits into from

Conversation

seemcat
Copy link
Contributor

@seemcat seemcat commented Jun 6, 2017

No description provided.

msach22
msach22 reviewed Jun 6, 2017
View reviewed changes
solutions/33.js
} else {
i++;
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seemcat you can condense this as:
while (i < arr.length) { if (num !== arr[i]) { newArr.push(arr[i]); } i++; }

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seemcat this change needs to be made.

yjlim5
yjlim5 requested changes Jun 13, 2017
View reviewed changes
solutions/33.js Outdated

const solution = (arr, num) => {
let i = 0;
let newArr = []
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a semicolon at the end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved. Thanks!

yjlim5
yjlim5 requested changes Jun 15, 2017
View reviewed changes
Copy link
Collaborator

@yjlim5 yjlim5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seemcat , just one more change to address and this PR will be good to go.

@seemcat
Copy link
Contributor Author

seemcat commented Jun 22, 2017 •
edited
Loading

@yjlim5 What changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msach22 msach22 msach22 left review comments

@yjlim5 yjlim5 yjlim5 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seemcat @yjlim5 @msach22