Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"private" keyword reports as "Required PHP 4.0.0 (min)" #119

Closed
cmb69 opened this issue Jun 15, 2014 · 2 comments
Closed

"private" keyword reports as "Required PHP 4.0.0 (min)" #119

cmb69 opened this issue Jun 15, 2014 · 2 comments
Assignees
Labels
Milestone

Comments

@cmb69
Copy link
Contributor

cmb69 commented Jun 15, 2014

PHP_CompatInfo 2.26.0 reports the following code as "Required PHP 4.0.0 (min)":

<?php

class Foo
{
    private $bar;

    private static $baz;
}

Private instance and all class (static) methods are reported as "Required PHP 5.0.0 (min)", as expected.

I have not been able to test with CompatInfo 3.1, because with a local composer install I can't execute compatinfo (Windows/Cygwin), due to wrong paths for required files.

@llaville llaville added the bug label Jun 16, 2014
@llaville llaville added this to the 3.2.0 milestone Jun 16, 2014
@llaville llaville self-assigned this Jun 16, 2014
@llaville
Copy link
Owner

I confirm, this issue affect both version 2.26 and 3.1

As I've decided to let down maintenance of branch 2, this bug will be fixed only on branch 3.

Thanks for your report

llaville added a commit that referenced this issue Jul 1, 2014
@llaville llaville closed this as completed Jul 1, 2014
@llaville
Copy link
Owner

llaville commented Jul 4, 2014

I've forgot to commit the new getClassName() method in Reflect\Model\PropertyModel : see commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants