defined() without string cannot be resolved and will be ignored

llaville · Sep 29, 2020 · 83492c2 · 83492c2
1 parent ec2718c
commit 83492c2
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/src/Bartlett/CompatInfo/DataCollector/Normalizer/NodeNormalizer.php b/src/Bartlett/CompatInfo/DataCollector/Normalizer/NodeNormalizer.php
@@ -35,6 +35,11 @@ public function normalize($node, $format = null, array $context = [])
             );
         }
 
+        if (empty($this->name)) {
+            // indirect called cannot be resolved and will be ignored
+            return null;
+        }
+
         $attributeParentKey = $context['nodeAttributeParentKeyStore'] ?? 'bartlett.parent';
         $attributeKey = $context['nodeAttributeKeyStore'] ?? 'bartlett.data_collector';
 
@@ -124,7 +129,13 @@ public function supportsNormalization($data, $format = null)
                 $this->name = (string) $data->getAttribute($this->attributeNamespacedName);
             }
         } elseif ($this->isConstantDefineExpression($data)) {
-            $this->name = $data->args[0]->value->value;
+            $name = $data->args[0]->value;
+            if ($name instanceof Node\Scalar\String_) {
+                $this->name = $name->value;
+            } else {
+                // indirect constant naming is not resolved
+                $this->name = '';
+            }
         } elseif ($data->hasAttribute($this->attributeNamespacedName)) {
             $this->name = (string) $data->getAttribute($this->attributeNamespacedName);
         } elseif (property_exists($data, 'name')) {