fixed issue GH-200 (goto statement)

llaville · May 12, 2015 · 28a5b2d · 28a5b2d
1 parent 79ccaf3
commit 28a5b2d
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 0 deletions.
diff --git a/src/Bartlett/CompatInfo/Analyser/CompatibilityAnalyser.php b/src/Bartlett/CompatInfo/Analyser/CompatibilityAnalyser.php
@@ -301,6 +301,9 @@ public function leaveNode(Node $node)
         ) {
             $this->computePhpFeatureVersions($node);
 
+        } elseif ($node instanceof Node\Stmt\Goto_) {
+            $this->computePhpFeatureVersions($node);
+
         } elseif ($node instanceof Node\Stmt\Const_) {
             foreach ($node->consts as $const) {
                 // user constant does not require to search in REF database
@@ -1122,6 +1125,10 @@ private function computePhpFeatureVersions(Node $node)
                 $versions = array('php.min' => '5.4.0');
                 $this->updateLocalVersions($versions);
             }
+
+        } elseif ($node instanceof Node\Stmt\Goto_) {
+            $versions = array('php.min' => '5.3.0');
+            $this->updateLocalVersions($versions);
         }
     }
 

diff --git a/tests/PhpFeaturesIssueTest.php b/tests/PhpFeaturesIssueTest.php
@@ -41,6 +41,7 @@ class PhpFeaturesIssueTest extends \PHPUnit_Framework_TestCase
     const GH148 = 'gh148.php';
     const GH154 = 'gh154.php';
     const GH168 = 'gh168.php';
+    const GH200 = 'gh200.php';
 
     protected static $fixtures;
     protected static $analyserId;
@@ -278,4 +279,30 @@ public function testBugGH168()
             $constants['FOO']
         );
     }
+
+    /**
+     * Regression test for feature GH#200
+     *
+     * @link https://github.com/llaville/php-compat-info/issues/200
+     *       goto statement is not checked
+     * @link http://php.net/manual/en/control-structures.goto.php
+     * @group features
+     * @return void
+     */
+    public function testFeatureGH200()
+    {
+        $dataSource = self::$fixtures . self::GH200;
+        $analysers  = array('compatibility');
+        $metrics    = self::$api->run($dataSource, $analysers);
+        $versions   = $metrics[self::$analyserId]['versions'];
+
+        $this->assertEquals(
+            array(
+                'php.min'      => '5.3.0',
+                'php.max'      => '',
+                'php.all'      => '5.3.0',
+            ),
+            $versions
+        );
+    }
 }
diff --git a/tests/fixtures/gh200.php b/tests/fixtures/gh200.php
@@ -0,0 +1,6 @@
+<?php
+goto a;
+echo 'Foo';
+
+a:
+echo 'Bar';