Measure Activity for Sugarizer

[abhishektanwar]

Developed the Measure Activity in sugar for Sugarizer.

[abhishektanwar]

#709

[quozl]

57b113c commit message is a bit brief. You could say what you used, like p5 sound.

I see you added exec = sugar-activity-web. Will you be porting this to Sugar or does it work already?

[abhishektanwar]

@quozl @llaske I am developing this activity for Sugarizer. Sugar has the measure activity and I took the inspiration from https://help.sugarlabs.org/measure.html .A few days ago I asked in sugar-devel to make this activity for sugarizer.
I have used the p5.js ,p5.sound and p5.dom libraries in this activity.
There is more work that needs to be done like plotting waveform for different octaves,play a sound and show how waveform is varying at different amplitudes.

[llaske]

Good start. Nice.

You should also adapt the UI to Sugarizer. Specifically, settings should be in a palette, not directly on the string. Plus the buttons in the toolbar should be selected/unselected instead of hidden.

[abhishektanwar]

@llaske Thanks for the feedback.
By settings do you mean the sliders at the bottom of the page ?
Also can the x-axis scale be shown on the graph or do I need to place it somewhere else?If I have to place it somewhere else,where should it be placed?
Working on suggestions.

[llaske]

Yes I mean the sliders.
Regarding the x-axis scale, may be you could place it at the bottom of the graph like in Measure activity.

[abhishektanwar]

Working on the suggestions.

[abhishektanwar]

@llaske I am finding difficulties in moving the sliders to the toolbar palette. As the current sliders have been made using p5.js and these sliders are directly linked to the waveforms if I am making any changes to these, everything breaks. Could you provide me some documentation for sliders in sugarizer . I have tried to implement the working of sliders from different activities but it didn't work.

[llaske]

@abhishektanwar sliders in Sugarizer is just HTML input with the type range. You could find a very basic sample here. It's used for example in Speak or Game of Life activities.
Regarding the current sliders related to p5.js code, may be you could just hide them.

[abhishektanwar]

@llaske thanks for the help it worked.
I have fixed all the requested changes. Please review.
Activity is complete now.

[abhishektanwar]

@ashish0910 @llaske removed console logs. Please review.

[llaske]

Mmmm. The activity does nothing on my side.
At start the screen is totally black:

When the graph button is clicked the activity seems to listen but nothing happen:

Plus will be nice to improve icons/slide bar proportions/alignement in palette:

[abhishektanwar]

@llaske @ashish0910 Waveform is plotted from the values of sliders (amplitude and frequency). Initially, the values of amplitude and frequency slider is 0(zero). As the sliders are moved, the corresponding waveform is plotted.

• Fixed alignment of icons and sliders in palette.
  Please review

[llaske]

So do not start with a value of zero for amplitude and frequency and display the waveform at launch.
Note sure to understand why sliders values change when switching graph?
Plus, will be nice to save values (and current graph selection) in the datastore so the user could reopen the activity to recover its context.

[abhishektanwar]

thanks for the feedback. working on it.

[abhishektanwar]

@llaske @ashish0910

• added datastore functionality
• fixed initial zero value of sliders
• on initializing an old instance of the activity , activity starts from previous slider settings and last waveform(time or frequency)
• saves current graph when activity is stopped

please review

[abhishektanwar]

I suggest to start the activity paused, in this case only (if on Chome and if file://).

I think to maintain the working of activity similar to for all the browsers , activity can be started with pause state (the button which is being used to pause the graph) and then the user can start the activity by clicking on play button or we can proceed as you suggested earlier by tweaking the pause button for chrome browser.

[llaske]

I'm not agree. The activity should start automatically.
Paused at startup is just a work around.

[abhishektanwar]

I'm not agree. The activity should start automatically.
Paused at startup is just a work around.

Okay then activity will start normally for all browsers . But for chrome ,activity will start with paused state . User will have to click play button.
Please let me know if this is fine.

[llaske]

But for chrome ,activity will start with paused state

For Chrome, only when run from file://

[llaske]

The activity no longer work on http:// :

[abhishektanwar]

can you layout the steps you followed to run this activity from the beginning . It worked fine on my side @llaske

[llaske]

Just cleaning the browser cache. Then launch a new instance of Measure.

[abhishektanwar]

@llaske there was one error . Fixed it . Please review again.

[llaske]

In http mode it works but the title "Sound time base" is displayed under graph:

In file mode the graph is not drawn correctly:

Try to do more testing before sending your PR.

[abhishektanwar]

@llaske it is working fine on my side in file mode .
If you are using some other method to testing other than I am using please let me know .
When in chrome and file mode , I am showing the empty graph ,user clicks on play button which also accounts for the policy of chrome that a user gesture is required for accessing microphone.

[llaske]

Do you clear your browser cache?

[abhishektanwar]

@llaske Yes, I have cleared all the cached files in the chrome browser.

[llaske]

Sound like it happens randomly. When it happens, there is a message file protocol error in the console:

Another issue, when switching graph in pause mode, a double graph appears:

[abhishektanwar]

Sound like it happens randomly. When it happens, there is a message file protocol error in the console:

What can we do with this?What do you recommend?

Another issue, when switching graph in pause mode, a double graph appears:

Yes it can happen because according to previous discussions activity was designed to switch between time and frequency graphs only when the graph is in play mode (not in pause state).

[llaske]

What can we do with this?What do you recommend?
Try to explore in which condition this can happen and fix it.

Yes it can happen
Okay but it should be solve. We can't let it like that.

[abhishektanwar]

Sound like it happens randomly. When it happens, there is a message file protocol error in the console:

I have tweaked the activity for chrome a bit . Please review it again . Works fine on mine side(tested after clearing cache)

Another issue, when switching graph in pause mode, a double graph appears:

Fixed

[llaske]

Still few issues:

• The graph should start automatically in Chrome when not in file mode. My request was to pause the activity at start in Chrome AND in file mode
• When the activity is reopened, the double background issue still appears:

• I've got several times the random error described before. Following is some screen capture when it happens. Did you have the issue sometimes on your side?

• Remove commented lines and //change comment

[llaske]

Replaced by #709