Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added docker exec command line 130 #383

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nitrophenol
Copy link

@nitrophenol nitrophenol commented Mar 6, 2023

adding docker exec command in readme.md

README.md Show resolved Hide resolved
@nitrophenol nitrophenol requested a review from NikhilM98 March 6, 2023 15:09
Copy link
Collaborator

@NikhilM98 NikhilM98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The destination branch for your PR should be dev, not master.

@@ -6,7 +6,6 @@

Sugarizer Server allows the deployment of Sugarizer on a local server, for example on a school server, so expose locally Sugarizer as a Web Application. Sugarizer Server can also be used to provide collaboration features for Sugarizer Application on the network. Sugarizer Server could be deployed in a Docker container or on any computer with Node.js 10+ and MongoDB 3.2+.


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary changes.

@@ -127,9 +126,14 @@ Sugarizer Server Dashboard is an admin tool for teachers and deployment administ
* Graphic and request: display graphics and report on previous data.

To login to the Dashboard the first time, you will have to create an admin account using this command:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some whitespace here.

sh add-admin.sh admin password http://127.0.0.1:8080/auth/signup

Incase using Docker to login the Dashboard for the first time

docker exec -it <id of sugarizer-server_server> bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also consider using docker-compose exec server bash instead of this command. That way we don't have to worry about the ID of the container. @nitrophenol can you test that?

@llaske what is your opinion on using docker-compose exec instead?

sh add-admin.sh admin password http://127.0.0.1:8080/auth/signup

Incase using Docker to login the Dashboard for the first time
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe replace Incase using Docker to login the Dashboard for the first time with something like If Sugarizer Server was deployed using Docker Compose, use these commands to create an admin account:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants