-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added docker exec command line 130 #383
base: master
Are you sure you want to change the base?
Conversation
updated port from 8080 to 80 for docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The destination branch for your PR should be dev
, not master
.
@@ -6,7 +6,6 @@ | |||
|
|||
Sugarizer Server allows the deployment of Sugarizer on a local server, for example on a school server, so expose locally Sugarizer as a Web Application. Sugarizer Server can also be used to provide collaboration features for Sugarizer Application on the network. Sugarizer Server could be deployed in a Docker container or on any computer with Node.js 10+ and MongoDB 3.2+. | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecessary changes.
@@ -127,9 +126,14 @@ Sugarizer Server Dashboard is an admin tool for teachers and deployment administ | |||
* Graphic and request: display graphics and report on previous data. | |||
|
|||
To login to the Dashboard the first time, you will have to create an admin account using this command: | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some whitespace here.
sh add-admin.sh admin password http://127.0.0.1:8080/auth/signup | ||
|
||
Incase using Docker to login the Dashboard for the first time | ||
|
||
docker exec -it <id of sugarizer-server_server> bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also consider using docker-compose exec server bash
instead of this command. That way we don't have to worry about the ID of the container. @nitrophenol can you test that?
@llaske what is your opinion on using docker-compose exec
instead?
sh add-admin.sh admin password http://127.0.0.1:8080/auth/signup | ||
|
||
Incase using Docker to login the Dashboard for the first time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe replace Incase using Docker to login the Dashboard for the first time
with something like If Sugarizer Server was deployed using Docker Compose, use these commands to create an admin account:
adding docker exec command in readme.md