filtering users by name and account type while exporting #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed permission error coming while installing docker compose in install.md
Fixed Permission error in install.md
|
issue #313 |
|
There are several changes which are not relevant to the issue (comments, unwanted spaces). Can you please remove them? Also, if you look at the git diff, you'll find some "end of line" errors, can you please get rid of them too? |
|
sure, I'll do that |
|
@NikhilM98 done |
llaske
requested changes
Jul 23, 2022
There was a problem hiding this comment.
Good job. It works and it's useful.
BTW it's no longer possible to export every users which is require.
I suggest to add an option to do that in the combo to allow Students/Teacher/Admin + All.
See also my comments below and remove comments on every line of your change.
| @@ -2,4 +2,4 @@ if ! [ $# -eq "3" ] ; then echo "You should provide user, password and URL" ; ex | |||
| newuser=$1 | |||
| newpassword=$2 | |||
| newobject="user=%7B%22name%22%3A%22${newuser}%22%2C%22role%22%3A%22admin%22%2C%22password%22%3A%22${newpassword}%22%2C%22language%22%3A%22en%22%7D" | |||
| curl -k -i -H "Content-Type: application/x-www-form-urlencoded" -X POST -d "${newobject}" $3 | |||
| curl -k -i -H "Content-Type: application/x-www-form-urlencoded" -X POST -d "${newobject}" $3 | |||
| @@ -14,7 +14,7 @@ To run Sugarizer Server using Docker and Docker Compose: | |||
|
|
|||
| Install Docker Compose | |||
|
|
|||
| curl -L "https://github.com/docker/compose/releases/download/1.8.1/docker-compose-$(uname -s)-$(uname -m)" > /usr/local/bin/docker-compose | |||
| curl -L "https://github.com/docker/compose/releases/download/1.8.1/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose | |||
| @@ -1,3 +1,4 @@ | |||
| version = 1.4.0 | |||
| @@ -1,12806 +1,8 @@ | |||
| { | |||
| "name": "sugarizer-server", | |||
| "version": "1.4.0", | |||
| "lockfileVersion": 2, | |||
| "lockfileVersion": 1, | |||
There was a problem hiding this comment.
Remove changes in this file from the PR
|
Closed due to lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the users are getting filtered according to account type and name when we export users, rather than exporting all the accounts , only the filtered accounts are getting downloaded