-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ansible package for easy deployment on GCP #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few remarks:
-
The
gce
module is deprecated.
As of Ansible 2.8, Ansible community is encouraging everyone to move from thegce
module to thegcp_compute_instance
module. Thegcp_compute_instance
module has better support for all of GCP’s features, fewer dependencies, more flexibility, and better supports GCP’s authentication systems.
Reference: 1 2 (Ansible Docs) -
There was no need to create Install Dependencies playbook. They can be installed in
ansible/deploy-to-gcp/gcp-start-script.sh
itself. -
What is
touch testing.js
command for inansible/deploy-to-gcp/gcp-start-script.sh
? -
Add an empty line as the end of each file.
-
The
ansible/deploy-to-gcp
has no direct dependence on the Sugarizer Server code, since it pulls a fresh copy of Sugarizer-Server from the GitHub. Also, theget_start_script
uses the code from GitHub even though the Start Script was already present in the system. Maybe instead of merging the Deploy to GCP in Sugarizer-Server, we can create another repository for the same (Like Sugarizer-APK-Builder and Sugarizer-School-Box). What do you think @llaske ?
@NikhilM98 Thanks for reviewing. I have made the suggested changes. Deprecated module Yes, ansible/deploy-to-gcp does not have any direct dependence upon Sugarizer Server Code that is why only this specific directory is downloaded to the user's local machine by steps mentioned in ansible/docs as we do not want the user to unnecessarily download the entire repository.
Ansible packages for other deployments methods too can be created in future and they can all be inside the ansible folder, I think it will promote gradual transition to using ansible as the preferred way to setup sugarizer-server specially by non-developers. However separating it into another repository is also a good option. What do you think? Requesting suggestions @llaske |
Have you tested providing If you can provide |
@NikhilM98 Thanks for suggestion. |
It looks better now. The reference link was added to point out that we can use Btw the file |
@NikhilM98 the unused image |
@mikklfr could you review this and see if it could be helpful for Sugarizer School Portal project. |
Hi! That's not linked with the school project technically as this approach is not about sharing a pool of resources for many schools but about setting up a single deploy. But that is nice and could simplify deployments for some. |
Okay. @ksraj123 could you:
|
@llaske Suggested changes made, please review.
|
Nice. Thanks. |
Fixes Issue #256
This ansible package simplifies the current deployment method for deploying sugarizer-server on vm instances on google compute engine.
It creates and configures a vm instance and firewall, installs dependencies and deploys sugarizer-server onto the vm instance, it also prints the external IP of the vm instance where the deployment can be accessed.
This could be tested with steps described in
ansible/docs/ansible-deployToGcp.md
of this PR.