Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show no result found message rather than Showing table headings #39

Closed
ashish0910 opened this issue Feb 28, 2019 · 5 comments
Closed

show no result found message rather than Showing table headings #39

ashish0910 opened this issue Feb 28, 2019 · 5 comments
Labels
enhancement to be release
Milestone
v1.1

Comments

@ashish0910
Copy link
Contributor

On searching for User or Classroom through search option it shows only headings of the table if no matching result is found . The idea is to show user that no User or Classroom matching your search found message rather than showing only Table headings .

screenshot 2019-02-28 at 6 11 37 pm
@ashish0910 ashish0910 changed the title show no result found rather than Showing Only table headings show no result found message rather than Showing table headings Feb 28, 2019
@llaske
Copy link
Owner

llaske commented Feb 28, 2019

Seems clear that there is no result found. It's the same behavior when looking for users.

@ashish0910
Copy link
Contributor Author

ashish0910 commented Mar 1, 2019 •
edited
Loading

Yes , It's the same behaviour when looking for users. Showing such messages helps in better user experience .
A message like this can be shown showing no User or Classroom found.
screenshot 2019-03-02 at 1 11 49 am

@tarunsinghal92
Copy link
Collaborator

@ashish0910 Could you please make a PR with a similar screen as shown above for classroom module.

@ashish0910 ashish0910 mentioned this issue Mar 2, 2019
Merged
@ashish0910
Copy link
Contributor Author

@tarunsinghal92 added in #44

tarunsinghal92 added a commit that referenced this issue Mar 3, 2019
@tarunsinghal92
Merge pull request #44 from ashish0910/messages
a292c95 
No user and classroom message issue #39
@llaske
Copy link
Owner

llaske commented Mar 10, 2019

Fixed in #44

@llaske llaske added this to the v1.1 milestone Mar 24, 2019
@llaske llaske closed this as completed Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement to be release
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
3 participants
@llaske @tarunsinghal92 @ashish0910